Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YEDIS] Add support for CLIENT command #985

Open
Negashev opened this issue Mar 13, 2019 · 10 comments
Open

[YEDIS] Add support for CLIENT command #985

Negashev opened this issue Mar 13, 2019 · 10 comments
Assignees
Labels
community/request Issues created by external users kind/enhancement This is an enhancement of an existing feature

Comments

@Negashev
Copy link

CLIENT command in YEDIS not exist

@kmuthukk kmuthukk added the kind/enhancement This is an enhancement of an existing feature label Mar 13, 2019
@kmuthukk
Copy link
Collaborator

hi @Negashev

Yes - this is not yet implemented. Could you share a little bit more about your use case for the CLIENT command? Is it a existing app or new application or you are using through some other framework (like Spring) and it happens to use the CLIENT * commands?

Are you looking for support for all of these commands, or some specific subset?

CLIENT GETNAME
CLIENT ID
CLIENT KILL
CLIENT LIST
CLIENT PAUSE
CLIENT REPLY
CLIENT SETNAME
CLIENT UNBLOCK

This will give us some helpful context on best next steps, scope of the work, or suggestions for using an alternate approach.

regards,
Kannan

@Negashev
Copy link
Author

@kmuthukk First is

CLIENT GETNAME
CLIENT SETNAME

next

CLIENT ID
CLIENT LIST

@kmuthukk
Copy link
Collaborator

hi @Negashev - could you elaborate on the use case for this a bit more? Do you need this mainly for debuggability?

@kmuthukk kmuthukk self-assigned this Mar 14, 2019
@Negashev
Copy link
Author

Negashev commented Mar 14, 2019

@kmuthukk It's dependency on sidekiq, client connect to redis pub/sub and use command CLIENT

@kmuthukk
Copy link
Collaborator

I see. Thanks a lot. That's helpful to know.

Does it also use the CLIENT ID and CLIENT LIST commands, or only CLIENT GETNAME/SETNAME commands?

@Negashev
Copy link
Author

Negashev commented Mar 14, 2019

@kmuthukk Yes! Found solution, turn off client call from application

@kmuthukk
Copy link
Collaborator

kmuthukk commented Mar 14, 2019

Nice.

Did you mean: Found solution (and not Find solution)? So sidekick allows you to turn it off?

@mysticaltech
Copy link

@Negashev So can you confirm that Sidekiq works with YugaByte? And how do you turn the client command off? This would be revolutionary for Ruby on Rails applications because you could theoretically replace both Postgres and Redis by one YugaByte cluster!

@Negashev
Copy link
Author

Negashev commented Apr 8, 2019

@mysticaltech So far I have failed, many dependencies, for example, the sscan key is needed further

@schoudhury schoudhury changed the title Add support for Redis CLIENT command in YugaByte YEDIS [YEDIS] Add support for CLIENT command May 21, 2019
@ttyusupov ttyusupov added the community/request Issues created by external users label Jul 16, 2019
@devthejo
Copy link

Need this too, to make it work with RedisUI
related to patrikx3/redis-ui#57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community/request Issues created by external users kind/enhancement This is an enhancement of an existing feature
Projects
Status: No status
Development

No branches or pull requests

5 participants