Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: prevent redirects (and possible MITM attacks) #1195

Closed
mfranzke opened this issue May 2, 2020 · 0 comments · Fixed by #1196
Closed

chore: prevent redirects (and possible MITM attacks) #1195

mfranzke opened this issue May 2, 2020 · 0 comments · Fixed by #1196

Comments

@mfranzke
Copy link
Contributor

mfranzke commented May 2, 2020 •
edited
Loading

We could prevent redirects to pages my linking to their "correct" / canonical URL directly.

Additionally not all of the websites we're linking to have introduced the "HTTP Strict Transport Security" (HSTS) mechanism to redirect securely to their HTTPS equivalent.
Nevertheless we could anyhow prevent that redirect independently from security aspects by linking to their HTTPS version of the website.

Maybe I`m a little too german on this, but at least I've prepared everything for an "easy" merge.
mfranzke pushed a commit to mfranzke/patternlab-node that referenced this issue May 2, 2020
chore(links): direct linking to those pages pattern-lab#1195
81a7085 
The link is missing a trailing slash, and caused a redirect. Adding the trailing slash would speed up browsing.
@mfranzke mfranzke mentioned this issue May 2, 2020
Merged
mfranzke pushed a commit to mfranzke/patternlab-node that referenced this issue May 2, 2020
chore(links): direct linking to the final URL pattern-lab#1195
a7f89c5 
This is a permanent redirect. The link should be updated.
mfranzke pushed a commit to mfranzke/patternlab-node that referenced this issue May 2, 2020
chore(links): direct linking to the final URL pattern-lab#1195
6f3e1b9 
This is a permanent redirect. The link should be updated.
mfranzke pushed a commit to mfranzke/patternlab-node that referenced this issue May 2, 2020
chore(links): direct linking to the final URL pattern-lab#1195
e913023 
This is a permanent redirect. The link should be updated.
mfranzke pushed a commit to mfranzke/patternlab-node that referenced this issue May 2, 2020
chore(links): direct linking to the final URL pattern-lab#1195
03fe1dd 
This is a permanent redirect. The link should be updated.
mfranzke pushed a commit to mfranzke/patternlab-node that referenced this issue May 2, 2020
chore(links): direct linking to the final URL pattern-lab#1195
1d9933d 
This is a permanent redirect. The link should be updated.
bmuenzenmeyer added a commit that referenced this issue May 5, 2020
@bmuenzenmeyer
Merge pull request #1196 from mfranzke/chore-prevent-redirects
a39d56f 
chore(links): prevent redirects both on internal as well as external URLs #1195
@mfranzke mfranzke mentioned this issue Jun 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@mfranzke