Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(links): prevent redirects both on internal as well as external URLs #1195 #1196

Merged
merged 8 commits into from
May 5, 2020

Conversation

mfranzke
Copy link
Contributor

@mfranzke mfranzke commented May 2, 2020

Some links are missing a trailing slash, and that for causing a redirect. Adding the trailing slash would speed up browsing.
Additionally linking to the correct (HTTPS version) of the pages would provide an additional aspect of "security".

Closes #1195

Summary of changes:
source (partly): https://validator.w3.org/checklink?uri=https%3A%2F%2Fpatternlab.io%2F&hide_type=all&recursive=on&depth=&check=Check

Maximilian Franzke added 6 commits May 2, 2020 17:53
The link is missing a trailing slash, and caused a redirect. Adding the trailing slash would speed up browsing.
This is a permanent redirect. The link should be updated.
This is a permanent redirect. The link should be updated.
This is a permanent redirect. The link should be updated.
This is a permanent redirect. The link should be updated.
This is a permanent redirect. The link should be updated.
@mfranzke mfranzke marked this pull request as ready for review May 2, 2020 16:48
@mfranzke mfranzke changed the title chore(links): prevent both redirects both on internal as well as external URLs #1195 chore(links): prevent redirects both on internal as well as external URLs #1195 May 2, 2020
@bmuenzenmeyer
Copy link
Member

Thank you so much @mfranzke !!!!

@bmuenzenmeyer bmuenzenmeyer merged commit a39d56f into pattern-lab:dev May 5, 2020
@mfranzke mfranzke deleted the chore-prevent-redirects branch May 5, 2020 11:10
@mfranzke
Copy link
Contributor Author

mfranzke commented May 5, 2020

Thank you so much @mfranzke !!!!

@bmuenzenmeyer at your service ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: prevent redirects (and possible MITM attacks)
3 participants