Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(releasenotes): PL v5.10.1 contributors partly incorrect #1215

Closed
mfranzke opened this issue Jun 3, 2020 · 3 comments
Closed

chore(releasenotes): PL v5.10.1 contributors partly incorrect #1215

mfranzke opened this issue Jun 3, 2020 · 3 comments

Comments

@mfranzke
Copy link
Contributor

mfranzke commented Jun 3, 2020

The release description on https://github.com/pattern-lab/patternlab-node/releases/tag/v5.10.1 includes some incorrect contributors mentions:

Support for manual viewport size input & reintroduce resize key combinations #1167 (@mfranzke @sghoweri @bmuenzenmeyer)

credits me, but should actually mention @JosefBredereck and @bradfrost instead.

Implement exclude tags feature. #1140 (drupal@pascalcrott.del @bmuenzenmeyer @sghoweri @mfranzke)

is missing @JosefBredereck

fix(uikitworkshop): preventing cropping pattern parts #1174 #1175 (mfr@nzke.net @sghoweri)

fix(docs): google lighthouse error - bg and text contrast ratio #1197 #1198 (mfr@nzke.net)

chore(docs): simple typo #1194 (mfr@nzke.net)

chore(links): prevent redirects both on internal as well as external URLs #1195 #1196 (mfr@nzke.net @bmuenzenmeyer)

fix(docs): resolving broken links in new docs site #1192 #1193 (mfr@nzke.net @bmuenzenmeyer)

just asking to use my github username instead of emailaddress here, please.

@mfranzke mfranzke changed the title PL v5.10.1 contributors partly incorrect chore(releasenotes): PL v5.10.1 contributors partly incorrect Jun 3, 2020
@stale
Copy link

stale bot commented Aug 2, 2020

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

@JosefBredereck
Copy link
Contributor

done

@mfranzke
Copy link
Contributor Author

done

Ehre wem Ehre gebührt ! ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants