Skip to content

Commit af88166

Browse files
committed
fix(pfFilterPanel): Updated filter results at mobile
1 parent 02054a8 commit af88166

File tree

4 files changed

+37
-3
lines changed

4 files changed

+37
-3
lines changed

src/filters/filter-panel/filter-panel-results.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,6 @@ <h5>
2424
</span>
2525
</li>
2626
</ul>
27-
<p><a class="clear-filters" ng-click="$ctrl.clearAllFilters()" ng-if="$ctrl.config.appliedFilters.length > 0">Clear All Filters</a></p>
27+
<p class="clear-filters"><a href="javascript:void(0);" ng-click="$ctrl.clearAllFilters()" ng-if="$ctrl.config.appliedFilters.length > 0">Clear All Filters</a></p>
2828
</span>
2929
</span>

src/filters/filters.less

Lines changed: 34 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,26 +66,53 @@ pf-filter-panel {
6666
}
6767
.list-inline > li {
6868
padding-right: 0;
69+
padding-left: 0;
70+
padding-bottom: 6px;
71+
margin-right: 4px;
72+
:last-child {
73+
margin-right: 0px;
74+
}
75+
@media (min-width: @screen-md-min) {
76+
padding-bottom: 2px;
77+
padding-left: 5px;
78+
margin-right: 0;
79+
}
6980
}
7081
.toolbar-pf-results {
7182
border-top: none;
7283
margin-left: 10px;
7384
vertical-align: middle;
7485
.single-label {
7586
padding: 6px;
87+
padding-bottom: 6px;
88+
@media (min-width: @screen-md-min) {
89+
padding-bottom: 8px;
90+
}
7691
.pf-filter-label-category {
7792
background-color: @color-pf-blue-500;
7893
font-weight: 700;
7994
padding-right: 2px;
8095
padding-left: 0;
96+
padding-bottom: 6px;
8197
}
8298
.pficon-close {
8399
padding-right: 6px;
84100
}
85101
}
102+
.clear-filters {
103+
margin-top: -10px;
104+
@media (min-width: @screen-md-min) {
105+
margin-top: 0px;
106+
}
107+
}
86108
p {
109+
display: block;
87110
padding-right: 10px;
88-
padding-left: 10px;
111+
padding-left: 0px;
112+
@media (min-width: @screen-md-min) {
113+
display: inline-block;
114+
padding-left: 10px;
115+
}
89116
}
90117
}
91118
}
@@ -94,6 +121,12 @@ pf-filter-panel {
94121
background-color: @color-pf-blue-300;
95122
font-weight: 700;
96123
padding: 6px;
124+
padding-bottom: 6px;
125+
margin-right: 6px;
126+
@media (min-width: @screen-md-min) {
127+
margin-right: 2px;
128+
padding-bottom: 8px;
129+
}
97130
.category-values {
98131
padding-left: 4px;
99132
}

styles/angular-patternfly.less

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
@import "../node_modules/patternfly/dist/less/color-variables.less";
2+
@import "../node_modules/bootstrap/less/variables.less";
23
@import "misc.less";
34
@import "../src/card/card.less";
45
@import "../src/charts/charts.less";

test/filters/filter-panel.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ describe('Directive: pfFilterPanel', function () {
152152
expect(tagOne).toContain("Value 2");
153153
expect(tagOne).not.toContain("Value 3");
154154

155-
var clearAll = element.find('.clear-filters');
155+
var clearAll = element.find('.clear-filters a');
156156
expect(clearAll.length).toBe(1);
157157
eventFire(clearAll[0], 'click');
158158
$scope.$digest();

0 commit comments

Comments
 (0)