Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skeleton loading #221

Closed
terezanovotna opened this issue Oct 16, 2018 · 22 comments
Closed

Skeleton loading #221

terezanovotna opened this issue Oct 16, 2018 · 22 comments
Assignees
Labels
template New page layout or edit to template file
Milestone

Comments

@terezanovotna
Copy link

This is an enhancement for an existing pattern.

Pattenfly Spinner could be substituted with skeleton loading which looks much cleaner on the screen. Or skeleton loading could be introduced as a new pattern to pick from when any information is being loaded.

47005198-e9c3d080-d13b-11e8-96b6-78b06d9fc004

46404134-9ba6da00-c704-11e8-9c40-13d242578a3d

The idea originated in theforeman/foreman#6103 (comment)

@mcarrano
Copy link
Member

Can you say more about this @terezanovotna ? Not sure exactly what the request is. Is it to incrementally load form data as it becomes available vs. waiting for all the data? Or is it a different kind of spinner element?

@terezanovotna
Copy link
Author

It is a suggestion/idea on using different visual to load data instead of a spinner. There is no high priority on this, but as the devs suggested it, I thought it could be a good idea to implement it in the future.

@katierik
Copy link

katierik commented Feb 18, 2019

Following up on this, I have a proposed design for how to use skeleton loaders & spinners together. This is going to be used in a product currently in development. One of the devs on the project (Ryan L) has been working on a "smart skeleton" which could be appropriate

Google share: https://docs.google.com/presentation/d/1kfKbl5HtumYiNm-ubJxxP93EqJjfThijEd6n1QIhD60/edit?usp=sharing
PDF copy of slides - message me

CC @mcarrano @rachael-phillips

@mcarrano
Copy link
Member

Fantastic work @katierik . I'd love to get this on the PF4 roadmap somewhere. @rachael-phillips what do you think?

@rachael-phillips
Copy link

Yes, absolutely. Skeleton loading is currently in our backlog, but if we decide this is something that we will work on the next few months we should definitely consider the skeleton loading designs that @katierik has put together! Spinner has been under design and development with PF4 over the past couple of days, so that component will be coming soon.

@ninavizz
Copy link

Hi @katierik! I tried opening/viewing your skeleton pattern, and got an "Access Denied" message. Is that intentional?

Looking forward to seeing a good Skeleton pattern added to Patternfly! I just discovered Patternfly, and am so delighted to see Redhat making this contribution to design. 😄

@andybraren
Copy link

andybraren commented Jul 1, 2019

+1’ing this potential new component. OpenShift has been working on some new dashboard designs, and we’d use this new pattern extensively while data is being loaded. Here’s a mockup of one card’s loading state:

health-1-0

@matthewcarleton put together this HTML/CSS example, and the Insights Storybook seems to have an even more refined React implementation that would be perfect for us too. I imagine the circular variant in the image above (for an undetermined status icon) could probably be done with a CSS class modifier on the same component.

@rachael-phillips
Copy link

@mcarrano should this be moved to the patternfly-next repo or it is ok for it to stay here for now?

@mcarrano
Copy link
Member

mcarrano commented Jul 1, 2019

@rachael-phillips Yes, this should be moved to the -next repo so we can track it.

@mcarrano mcarrano transferred this issue from patternfly/patternfly-design Jul 1, 2019
@mcarrano mcarrano changed the title Loading spinner -> skeleton loading Skeleton loading Aug 19, 2019
@mcarrano mcarrano transferred this issue from patternfly/patternfly Dec 16, 2019
@mcarrano
Copy link
Member

@LHinson per our discussion, we should get this on the roadmap.

@doruskova
Copy link
Collaborator

@mcarrano I'm adding a link to my exploration about skeleton loading - Skeleton Marvel It does include the guideline about

  • what's skeleton, when to use skeleton and when not
  • how to use it and when to use both (skeleton and spinner together)
  • how the skeleton may look like (a card, table) >> this depends on a shape of data

@doruskova
Copy link
Collaborator

@mcarrano I'm adding a design for a slow wave motion from the left to the right
Codepen preview

@mcarrano
Copy link
Member

This looks good @doruskova . @mceledonia can you also take a look?

@mceledonia
Copy link

@mcarrano @doruskova Looks good to me as well!

@mcarrano
Copy link
Member

@mcoker , can you take a look at the CodePen above and let us know if you see any technical issues with implementing the animation effect? If we are good to go with this, I will open a core issue. Looks like this is scheduled for milestone 2020.09.

@mcoker
Copy link

mcoker commented May 11, 2020

@mcarrano looks great to me!

@doruskova
Copy link
Collaborator

@mcarrano Design guideline specification is available here

@mcarrano
Copy link
Member

Thanks @doruskova . This looks great! I have opened core issue: patternfly/patternfly#3105 to track implementation and also patternfly/patternfly-org#1842 to add design guidelines.

@mcarrano mcarrano transferred this issue from patternfly/patternfly-design May 18, 2020
@gdoyle1 gdoyle1 added the symbol New addition or edit to symbol library label May 18, 2020
@gdoyle1 gdoyle1 added this to the 2020.06 milestone May 18, 2020
@gdoyle1 gdoyle1 added this to Backlog in PatternFly design kit Jun 30, 2020
@gdoyle1 gdoyle1 added the template New page layout or edit to template file label Jul 21, 2020
@gdoyle1 gdoyle1 moved this from Backlog to In progress in PatternFly design kit Jul 21, 2020
@gdoyle1 gdoyle1 modified the milestones: 2020.06, 2020.10, 2020.11 Sep 4, 2020
@gdoyle1 gdoyle1 modified the milestones: 2020.11, 2020.12 Sep 23, 2020
@doruskova doruskova modified the milestones: 2020.12, 2020.13 Sep 24, 2020
@doruskova
Copy link
Collaborator

@gdoyle1 @mceledonia Is this issue on hold?

@gdoyle1
Copy link
Collaborator

gdoyle1 commented Sep 29, 2020

Not that I know of @doruskova ! @mceledonia can you still take this on?

@doruskova doruskova modified the milestones: 2020.13, 2020.14 Oct 8, 2020
@doruskova doruskova self-assigned this Oct 14, 2020
@doruskova doruskova added bug Something isn't working on hold Holding work until the component is developed and removed bug Something isn't working on hold Holding work until the component is developed symbol New addition or edit to symbol library labels Oct 21, 2020
@doruskova
Copy link
Collaborator

Skeleton symbols merged!

@doruskova
Copy link
Collaborator

Template merged!

@doruskova doruskova moved this from In progress to Done in PatternFly design kit Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
template New page layout or edit to template file
Development

No branches or pull requests

10 participants