Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

styles doesn't work with UMD #2674

Closed
ssilvert opened this issue Aug 8, 2019 · 9 comments · Fixed by #2724
Closed

styles doesn't work with UMD #2674

ssilvert opened this issue Aug 8, 2019 · 9 comments · Fixed by #2724
Assignees
Labels
PF4 React issues for the PF4 core effort

Comments

@ssilvert
Copy link

ssilvert commented Aug 8, 2019

It looks like this commit broke my app:

#2085

I'm not sure how this is supposed to be consumed now. Now it looks like react-styles is looking for files like ...components/Alert/alert.js?

Those don't exist in the react-styles distribution.

@rachael-phillips
Copy link
Contributor

@ssilvert this is the bug that's currently blocking you, correct?

@rachael-phillips rachael-phillips added the PF4 React issues for the PF4 core effort label Aug 9, 2019
@ssilvert
Copy link
Author

ssilvert commented Aug 9, 2019

@rachael-phillips Correct. It's a blocker.

@rachael-phillips
Copy link
Contributor

@dgutride I know you were looking at this with @ssilvert . What was the outcome of that and what should our next steps be?

@ssilvert
Copy link
Author

@rachael-phillips Is anyone looking at this?

@redallen
Copy link
Contributor

What do you need to require() CSS in the UMD world @ssilvert? Do you have something like css-loader? How was importing components working before since they've always had require('./about-modal-box.css')?

@ssilvert
Copy link
Author

@redallen @rachael-phillips It doesn't look like anything was done about react-styles with UMD.

I still get the same errors with the latest patternfly-react.

@redallen
Copy link
Contributor

#2724 was done. You can see it in the history above. Let's move discussion to ssilvert/systemjs-react#1 , I don't think this is a PatternFly issue.

ssilvert added a commit to ssilvert/systemjs-react that referenced this issue Oct 22, 2019
@dgutride
Copy link
Member

dgutride commented Nov 6, 2019

Unfortunately, this is still broken and we need to help prioritize a fix for it.

@dgutride dgutride reopened this Nov 6, 2019
@redallen
Copy link
Contributor

Fixed in ssilvert/systemjs-react#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PF4 React issues for the PF4 core effort
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants