Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charts: Theme examples #3015

Closed
dlabrecq opened this issue Sep 26, 2019 · 0 comments · Fixed by #3023
Closed

Charts: Theme examples #3015

dlabrecq opened this issue Sep 26, 2019 · 0 comments · Fixed by #3023
Assignees
@dlabrecq
Milestone
2019.09

Comments

@dlabrecq
Copy link
Member

A custom theme is typically applied to multiple charts, while style properties are applied to individual charts. As a user, I would like to view examples of the different approaches.

An example showing how to create a custom theme that overrides default padding and colors. And as an alternative, an example showing how to override those same properties via the chart's style attribute.

These examples should be in its own "Theme" area, similar to the Sparline examples.
@dlabrecq dlabrecq self-assigned this Sep 26, 2019
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Sep 27, 2019
@dlabrecq
chore(charts): add custom theme example
0b65600 
Fixes patternfly#3015
@dlabrecq dlabrecq mentioned this issue Sep 27, 2019
Merged
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Sep 27, 2019
@dlabrecq
chore(charts): add custom theme example
58a7b78 
Fixes patternfly#3015
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Sep 27, 2019
@dlabrecq
chore(charts): add custom theme example
67f94fc 
Fixes patternfly#3015
@tlabaj tlabaj added this to the Prioritized Backlog milestone Sep 27, 2019
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Sep 27, 2019
@dlabrecq
chore(charts): add custom theme example
a0a084b 
Fixes patternfly#3015
@tlabaj tlabaj modified the milestones: Prioritized Backlog, 2019.09 Oct 1, 2019
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Oct 1, 2019
@dlabrecq
chore(charts): add custom theme example
52e5ace 
Fixes patternfly#3015
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Oct 2, 2019
@dlabrecq
chore(charts): add custom theme example
c09b402 
Fixes patternfly#3015
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Oct 2, 2019
@dlabrecq
chore(charts): add custom theme example
d8a59ca 
Fixes patternfly#3015
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Oct 3, 2019
@dlabrecq
chore(charts): add custom theme example
221d173 
Fixes patternfly#3015
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Oct 3, 2019
@dlabrecq
chore(charts): add custom theme example
d0180c0 
Fixes patternfly#3015
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Oct 3, 2019
@dlabrecq
chore(charts): add custom theme example
9d3c8d9 
Fixes patternfly#3015
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Oct 3, 2019
@dlabrecq
chore(charts): add custom theme example
a1ab96d 
Fixes patternfly#3015
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Oct 3, 2019
@dlabrecq
chore(charts): add custom theme example
e51fec4 
Fixes patternfly#3015
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Oct 3, 2019
@dlabrecq
chore(charts): add custom theme example
b61871c 
Fixes patternfly#3015
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Oct 3, 2019
@dlabrecq
chore(charts): add custom theme example
5514796 
Fixes patternfly#3015
tlabaj pushed a commit that referenced this issue Oct 3, 2019
@dlabrecq @tlabaj
Charts: Add custom theme example (#3023)
b394a58 
* fix(charts): add textAnchor, transform, & verticalAnchor props to ChartLabel

Fixes #3027

* chore(charts): add custom theme example

Fixes #3015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dlabrecq dlabrecq

Labels
None yet
Projects
None yet
Milestone
2019.09
Development

Successfully merging a pull request may close this issue.

Charts: Add custom theme example dlabrecq/patternfly-react
2 participants
@dlabrecq @tlabaj