Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(form): update text in form component #2352

Merged
merged 2 commits into from
Jun 25, 2019
Merged

fix(form): update text in form component #2352

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3626cad
Fix typo
jessiehuff Jun 25, 2019
4221545
Change wording
jessiehuff Jun 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/patternfly-4/react-core/src/components/Form/Form.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class SimpleForm extends React.Component {
return (
<Form>
<FormGroup
label="Required Name"
label="Name"
isRequired
fieldId="simple-form-name"
helperText="Please provide your full name"
Expand All @@ -75,7 +75,7 @@ class SimpleForm extends React.Component {
onChange={this.handleTextInputChange1}
/>
</FormGroup>
<FormGroup label="Required Email" isRequired fieldId="simple-form-email">
<FormGroup label="Email" isRequired fieldId="simple-form-email">
<TextInput
isRequired
type="email"
Expand All @@ -96,7 +96,7 @@ class SimpleForm extends React.Component {
onChange={this.handleTextInputChange3}
/>
</FormGroup>
<FormGroup isInline label="required How can we contact you?" isRequired fieldId="inline-radio1">
<FormGroup isInline label="How can we contact you?" isRequired fieldId="inline-radio1">
<Radio id="inlineradio1" name="inlineradios" label="Email" aria-label="Email" />
<Radio id="inlineradio2" name="inlineradios" label="Phone" aria-label="Phone" />
<Radio
Expand Down Expand Up @@ -176,7 +176,7 @@ class HorizontalForm extends React.Component {
return (
<Form isHorizontal>
<FormGroup
label="Required Name"
label="Name"
isRequired
fieldId="horizontal-form-name"
helperText="Please provide your full name"
Expand Down