feat(Popper, misc): update reference to triggerRef, components to use popperRef/triggerRef #8733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-8733.surge.sh A11y report: https://patternfly-react-pr-8733-a11y.surge.sh |
kmcfaul
force-pushed
the
popper-pipe-refs
branch
from
5d4807d
to
04684df
Compare
|
Noticed a bit of an odd behavior while I was fixing an integration test where when the window is narrowed, there is a white space that is added to the right of the screen of the demo app. I've went back and tested this on a plain v5 branch and still see the issue, so I'm not sure what's going on. For now I've updated the test.
|
thatblindgeye
requested changes
Feb 23, 2023
packages/react-core/src/components/ClipboardCopy/ClipboardCopyButton.tsx
Show resolved
Hide resolved
thatblindgeye
approved these changes
Feb 23, 2023
nicolethoen
approved these changes
Feb 27, 2023
There was a problem hiding this comment.
I opened a follow up codemod issue patternfly/pf-codemods#296
@kmcfaul i'd love if you double check that there are no other breaking changes in this PR we should note in the codemod issue.
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This was referenced Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #8481
referencetotriggerRef.Popperto passtriggerRefandpopperRefso the wrapping divs are removed.reftoInputGroup(forSearchInput).triggerwithtriggerRefto minimize the amount of structural changes.TooltipandPopoverrequiretriggerRefto remove the wrapping div on the trigger, other components should include the references automatically. Not all components have exposedrefprops so they use internal refs to pass to Popper.