-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added property to set whether the outline is hull or rect #114
added property to set whether the outline is hull or rect #114
Conversation
@jenny-s51 @nicolethoen Could you PTAL? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution @leandroberetta ! Visually this is looking good - just a couple of comments:
It looks like when shift+clicking+dragging a node, the default behavior should move it out of a group. When this new prop is added, I can no longer seem to move the node out of the group. Is this to be expected?
Nit: I'm also wondering since the hulled outline was already the default and these changes introduce the rectangular outline, should we rename it to something like rectOutline
instead? I think semantically this makes more sense and we could just set rectOutline
instead of setting manually the prop value to false, however this isn't a blocker.
cc @jeff-phillips-18 what do you think?
I'm in favor of the |
Fix for dragging out of rect group, adds option to Node Options for rectangle groups
@jenny-s51, thanks for the review, @jeff-phillips-18 helped me with the issue you reported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @leandroberetta @jeff-phillips-18 latest changes LGTM 🚀
🎉 This PR is included in version 5.2.0-prerelease.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes #113
Description
A new property in the DefaultGroup was added to set whether the outline of the group is hulled or rect.
Type of change
Screen shots / Gifs for design review