Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(onerepo): add stack trace to config/setup failure #719

Merged
merged 1 commit into from
May 24, 2024

Conversation

paularmstrong
Copy link
Owner

Problem:

Startup/configuration errors are missing full stack traces. They aren't super clear that it's not really oneRepo's fault.

Solution:

Use (e as Error)?.stack if available.

Related issues:

Checklist:

  • Added or updated tests
  • Added or updated documentation
  • Ensured the pre-commit hooks ran successfully

By opening this pull request, you agree that this submission can be released under the same License that covers the project.

Copy link

netlify bot commented May 24, 2024

Deploy Preview for onerepo canceled.

Name Link
🔨 Latest commit 89b96ae
🔍 Latest deploy log https://app.netlify.com/sites/onerepo/deploys/66511465f5d70a000886fb79

@paularmstrong paularmstrong merged commit 4b0ac6c into main May 24, 2024
20 checks passed
@paularmstrong paularmstrong deleted the include-full-stack branch May 24, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant