Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open-ended box gets too tall #7

Closed
ZenithDK opened this issue Aug 11, 2016 · 5 comments
Closed

Open-ended box gets too tall #7

ZenithDK opened this issue Aug 11, 2016 · 5 comments
Labels

Comments

@ZenithDK
Copy link

I think the code does not substract the extra length that the tabs normally consume - so when I want a 50 mm high box, it is 53 mm tall (3 mm thick material).
So that is what you would have your inner dimensions reduced by if the lid/bottom was there.

@paulh-rnd
Copy link
Owner

Yeah, I vaguely remember running into that, you're quite right that it
should be shorter. Can;t fix this for a while as I'm busy, but I'll take a
look. Thanks.

On 11 August 2016 at 21:44, Lasse Bigum notifications@github.com wrote:

I think the code does not substract the extra length that the tabs
normally consume - so when I want a 50 mm high box, it is 53 mm tall (3 mm
thick material).
So that is what you would have your inner dimensions reduced by if the
lid/bottom was there.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#7, or mute the thread
https://github.com/notifications/unsubscribe-auth/AJw762Q43H46WzMMlj_E3ROsUSuNiFUUks5qewsIgaJpZM4JiCct
.

@ZenithDK
Copy link
Author

No worries, it doesn't ruin my design, but I thought it would be a nice fix going forward.
If I get time I might take the time to look at it myself.

@paulh-rnd paulh-rnd added the bug label Aug 15, 2016
@paulh-rnd
Copy link
Owner

@ZenithDK I've confirmed this was a bug, and it was also a problem for all the other options as well, besides the fully-enclosed box. I've fixed this up now, please test and let me know if you're happy with the results.

@ZenithDK
Copy link
Author

@paulh-rnd Awesome - thanks a lot - I appreciate this and your responsiveness.
I will be doing smaller projects over the next few weeks so I hope to get it well tested in that time :-)

@ZenithDK
Copy link
Author

I think we should close this for now as I can just re-open if there's still any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants