-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open-ended box gets too tall #7
Comments
Yeah, I vaguely remember running into that, you're quite right that it On 11 August 2016 at 21:44, Lasse Bigum notifications@github.com wrote:
|
No worries, it doesn't ruin my design, but I thought it would be a nice fix going forward. |
@ZenithDK I've confirmed this was a bug, and it was also a problem for all the other options as well, besides the fully-enclosed box. I've fixed this up now, please test and let me know if you're happy with the results. |
@paulh-rnd Awesome - thanks a lot - I appreciate this and your responsiveness. |
I think we should close this for now as I can just re-open if there's still any issues. |
I think the code does not substract the extra length that the tabs normally consume - so when I want a 50 mm high box, it is 53 mm tall (3 mm thick material).
So that is what you would have your inner dimensions reduced by if the lid/bottom was there.
The text was updated successfully, but these errors were encountered: