Iframe detection #10
Merged
Iframe detection #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* paulirish/master: Detect permissions.query.toString() overwrite (paulirish#7) Add permissions.query to `__proto__` to fool `hasOwnProperty` (paulirish#6)
* paulirish/master: v1.1.0 evasion: Use Proxy to better fake toString (paulirish#8)
|
Hah. this PR really sent me on a journey.
But note this iframe uses Anyhow, if you use the [src] attribute, like I'm not sure why there's a difference here, but it at least seems related to this report: puppeteer/puppeteer#1106 |
|
I think i've found two chromium bugs, thanks to this PR. ;) details in puppeteer/puppeteer#1106 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tricky detection. We can use an iframe to get a fresh
windowobject and use that to potential rerun all the tests we did on the firstwindowobject.I mocked the tests for this to show how it would go. The
apply-evasionscript should be injected into each JS context and not only the first one.