Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detailCalloutAccessoryView #44

Merged
merged 4 commits into from
Apr 28, 2023
Merged

detailCalloutAccessoryView #44

merged 4 commits into from
Apr 28, 2023

Conversation

RomanPodymov
Copy link

Hello.
Thank you for Map.
Added detailCalloutAccessoryView.

@pauljohanneskraft
Copy link
Owner

pauljohanneskraft commented Apr 20, 2023

Thank you very much for your contribution!

I would love to have a solution without the use of AnyView actually, but this would simply be a bit of rewriting (e.g. making a generic constraint on MapPin and then using EmptyView as a default value, if there is no view associated with it). I see that even your initial implementation made use of that - is there a reason on why you switched to AnyView?

In this PR, you seem to only add a detailCalloutAccessoryView to MapPin, is there a specific reason for that?

@RomanPodymov
Copy link
Author

Thank you very much for your contribution!

I would love to have a solution without the use of AnyView actually, but this would simply be a bit of rewriting (e.g. making a generic constraint on MapPin and then using EmptyView as a default value, if there is no view associated with it). I see that even your initial implementation made use of that - is there a reason on why you switched to AnyView?

In this PR, you seem to only add a detailCalloutAccessoryView to MapPin, is there a specific reason for that?

Hello @pauljohanneskraft
AnyView was sufficient for my project, that's why I use it. But I can add a generic type for detailCalloutAccessoryView. And I use MapPin only, but I can add this feature to the other annotations.

@pauljohanneskraft
Copy link
Owner

That would both be perfect - thank you very much 😊

@RomanPodymov
Copy link
Author

That would both be perfect - thank you very much 😊

Done.

@RomanPodymov
Copy link
Author

Hello @pauljohanneskraft
Any updates?

@pauljohanneskraft
Copy link
Owner

Sorry for not responding - I will merge it into another branch, make some adaptions and then release it in the coming days (or maybe I'm finished earlier, not sure yet).

@pauljohanneskraft pauljohanneskraft changed the base branch from main to detailCalloutAccessoryView April 28, 2023 15:43
@pauljohanneskraft pauljohanneskraft merged commit 14b5fbf into pauljohanneskraft:detailCalloutAccessoryView Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants