Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify package install #37

Merged
merged 3 commits into from
Jan 13, 2013
Merged

Simplify package install #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
381f059
.npmignore: Add entries from .gitignore, remove unnecessary
isaacs Jan 13, 2013
8e7ad68
package.json: Simplify install/prepublish scripts
isaacs Jan 13, 2013
d34a529
Move test script to package.json, remove setup.js
isaacs Jan 13, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 33 additions & 6 deletions .npmignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,35 @@
.lock-wscript
.svn/
.hg/
.git/
CVS/
*~
*.bak
.DS_Store
*.diff
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these should be in your home folder .gitignore file. .gitignore files that are checked into a repository should only include files associated with the repository.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh. this is npmignore. still, wtf.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everyone keeps saying that. I have .gitignore in my home dir with the contents. Why i’m getting .DS_Store shit in git repos every time then?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you have this in your global git config?

[core]
  excludesfile = ~/.gitignore

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep you're missing that in https://github.com/paulmillr/dotfiles/blob/master/home/gitconfig

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay it works

thanks dude. I was tired of having this in my every repo.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no opinions about this, myself. I just copied the relevant .gitignore rules into the .npmignore file. (Some files, such as .DS_Store and .svn and .git are always ignored by npm, no matter what.)

*.err
*.orig
*.log
*.rej
*.swo
*.swp
*.vi
*.sass-cache

.cache
.project
.settings
.tmproj
nbproject

# Dreamweaver added files
_notes
dwsync.xml

# Komodo
*.komodoproject
.komodotools

# Folders to ignore
intermediate
publish
.idea

*.sublime-project
*.sublime-workspace

test/fixtures/subdir/
6 changes: 2 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,8 @@
"node": "~0.6.10 || 0.7 || 0.8 || 0.9"
},
"scripts": {
"prepublish": "node setup.js prepublish",
"postpublish": "node setup.js postpublish",
"test": "node setup.js test",
"postinstall": "node setup.js test"
"prepublish": "coffee -o lib/ src/",
"test": "mocha --compilers coffee:coffee-script --require test/common.js --colors"
},
"dependencies": {},
"devDependencies": {
Expand Down
65 changes: 0 additions & 65 deletions setup.js
View file
Open in desktop

This file was deleted.