Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for "square" Cooler files #249

Merged
merged 29 commits into from
Sep 16, 2024
Merged

Conversation

robomics
Copy link
Contributor

See #225
Closes #225

@robomics robomics added the enhancement New feature or request label Sep 12, 2024
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 37.09677% with 78 lines in your changes missing coverage. Please review.

Project coverage is 74.24%. Comparing base (52bd468) to head (f59bbf0).

Files with missing lines Patch % Lines
...hictk/file/include/hictk/impl/utils_merge_impl.hpp 0.00% 43 Missing ⚠️
src/hictk/validate/validate.cpp 41.66% 7 Missing ⚠️
...ooler/include/hictk/cooler/impl/file_read_impl.hpp 75.00% 7 Missing ⚠️
src/hictk/cli/cli_convert.cpp 25.00% 6 Missing ⚠️
src/hictk/cli/cli_zoomify.cpp 0.00% 3 Missing and 2 partials ⚠️
...ler/include/hictk/cooler/impl/utils_merge_impl.hpp 25.00% 3 Missing ⚠️
...oler/include/hictk/cooler/impl/validation_impl.hpp 40.00% 3 Missing ⚠️
src/hictk/cli/cli_fix_mcool.cpp 50.00% 2 Missing ⚠️
.../include/hictk/cooler/impl/pixel_selector_impl.hpp 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
- Coverage   74.48%   74.24%   -0.25%     
==========================================
  Files         144      144              
  Lines       12479    12524      +45     
  Branches     1445     1450       +5     
==========================================
+ Hits         9295     9298       +3     
- Misses       1991     2031      +40     
- Partials     1193     1195       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robomics
Copy link
Contributor Author

The integration tests are expected to fail because the test dataset used by this branch contains the updated files required by #244.

It is not worth creating a temporary test dataset just for this branch.
Once #249 and #244 are both merged, the tests should (hopefully!) pass.

@robomics robomics merged commit 8449335 into main Sep 16, 2024
49 of 64 checks passed
@robomics robomics deleted the feature/cooler-asymmetric branch September 16, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant