Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace handlebars with custom templates #13

Merged
merged 3 commits into from
Jan 28, 2024

Conversation

chmielulu
Copy link
Contributor

Hello! Appreciate your library share :)

I noticed the use of handlebars in your code, which poses an issue when integrating with Next.js due to Webpack's lack of support for handlebars. To address this, I've made adjustments by replacing handlebars with template functions that generate template strings.

If you're interested, I've created a modified version that you can consider merging. Nevertheless, I'm planning to create a separate npm package with these changes for my Next.js project in the meantime. Let me know your thoughts! :)

@pawel-id pawel-id changed the title Enhancing Compatibility for Next.js Integration Replace handlebars with custom templates Jan 28, 2024
@pawel-id
Copy link
Owner

Thank you for contribution.

@pawel-id pawel-id merged commit 52849cc into pawel-id:master Jan 28, 2024
1 of 2 checks passed
@chmielulu chmielulu deleted the feat/remove-handlebars branch January 28, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants