Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving latitude and longitude instead of providing API secret key throws error #2

Closed
Nischay-Pro opened this issue Jun 8, 2021 · 3 comments · Fixed by #21
Closed
Assignees
Labels
🔨 Feature New feature or request
Milestone

Comments

@Nischay-Pro
Copy link

Nischay-Pro commented Jun 8, 2021

In the settings panel, when saving latitude and longitude and leaving API key empty throws both a Success Settings Updated and an External API Request Failed error.

I'm using the docker build with the latest tag.

@pawelmalak
Copy link
Owner

That is an intended behavior. You are getting Settings Updated message which means that new config was successfully saved to the database. External API Request Failed is then thrown because API key is missing and request to Weather API cannot be done without it.

@pawelmalak pawelmalak added the question Further information is requested label Jun 8, 2021
@Nischay-Pro
Copy link
Author

Ah. Perhaps maybe add some instruction on how to use this feature in the README. On first glace I thought just specifying geographic co-ordinates was enough. Some sort of text validation when user fills up partially to inform user that the field is compulsory if they wish to use the weather feature.

@pawelmalak
Copy link
Owner

Good idea. Will add information about it next to the input field and emit notification if lat&long are set but api key is missing.

@pawelmalak pawelmalak self-assigned this Jun 9, 2021
@pawelmalak pawelmalak added 🔨 Feature New feature or request and removed question Further information is requested labels Jun 9, 2021
@pawelmalak pawelmalak added this to the Version 1.2 milestone Jun 9, 2021
@pawelmalak pawelmalak linked a pull request Jun 10, 2021 that will close this issue
aroberts pushed a commit to aroberts/flame that referenced this issue Apr 10, 2023
aroberts pushed a commit to aroberts/flame that referenced this issue Apr 10, 2023
aroberts pushed a commit to aroberts/flame that referenced this issue Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 Feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants