Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL in Bookmark deletes Colon #5

Closed
SirConius opened this issue Jun 8, 2021 · 4 comments · Fixed by #9
Closed

URL in Bookmark deletes Colon #5

SirConius opened this issue Jun 8, 2021 · 4 comments · Fixed by #9
Labels
🔨 Feature New feature or request
Milestone

Comments

@SirConius
Copy link

When adding a url with a http:// or a https:// it will delete the colon:
Layer-3 Public CDN - ID 010034

While looking at the bookmark via the editor it does show the colon:
Layer-3 Public CDN - ID 010034

@pawelmalak
Copy link
Owner

Right now only IP addresses and FQDN (Fully Qualified Domain Name) are supported so reddit.com should work.

For now I'll add warning to the form to avoid further confusion but in the future I'm planning on implementing some kind of url parser to allow wider range of addresses.

@pawelmalak pawelmalak added the 🔨 Feature New feature or request label Jun 8, 2021
@pawelmalak pawelmalak added this to the QoL Improvements milestone Jun 8, 2021
@pawelmalak pawelmalak added this to In Progress in Flame Project Board Jun 8, 2021
@pawelmalak pawelmalak moved this from In Progress to Done in Flame Project Board Jun 8, 2021
@vp-lab
Copy link

vp-lab commented Jun 9, 2021

It would be nice to be able to use like this:

Most of us we'll use this for internal too 🖥️
It's the most beautiful UI for apps and bookmarks.

Hope we'll get this feature soon.

@pawelmalak
Copy link
Owner

You should be able to use ip address now, e.g.: 192.168.0.128:5021 should redirect to http://192.168.0.128:5021

@vp-lab
Copy link

vp-lab commented Jun 9, 2021

With http it's working but with https isn't working:
ex: Proxmox 10.0.11.240:8006 (that's on my application settings)

If I put https:// it'll delete the : after https

aroberts pushed a commit to aroberts/flame that referenced this issue Apr 10, 2023
* allow custom icons for bookmarks

* update docker-image action to tag images based on source branch
aroberts pushed a commit to aroberts/flame that referenced this issue Apr 10, 2023
* allow custom icons for bookmarks

* update docker-image action to tag images based on source branch
aroberts pushed a commit to aroberts/flame that referenced this issue Apr 10, 2023
* allow custom icons for bookmarks

* update docker-image action to tag images based on source branch
aroberts pushed a commit to aroberts/flame that referenced this issue Apr 10, 2023
* allow custom icons for bookmarks

* update docker-image action to tag images based on source branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 Feature New feature or request
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants