fix "#pragma option" crash when character count is over 31 #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason `i` will be `32` after our for loop so an OOB happens when code tries to assign `'\0'` to `name[32]` since `name` size is 32. Doing a `-1` to `i` fixed this issue and now throws `error 038: extra characters on line` when character count is over 31.
Southclaws
approved these changes
Oct 7, 2019
Y-Less
requested changes
Oct 7, 2019
|
Simpler fix: Instead of |
Y-Less
approved these changes
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #359
What kind of pull this is:
Additional Documentation:
For some reason
iwill be32after our for loop so an OOB happens when code tries to assign'\0'toname[32]sincenamesize is 32.Doing a
-1toifixed this issue and now throwswhen character count is over 31.
Also I'm not sure if I should change
namesize and make it able to accept more than 31 characters, since file paths can be more than 31 characters of course