Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed references to Rails.applications.secrets #834

Merged
merged 4 commits into from
Jul 18, 2023
Merged

Removed references to Rails.applications.secrets #834

merged 4 commits into from
Jul 18, 2023

Conversation

heliocola
Copy link
Contributor

@heliocola heliocola commented Jul 17, 2023 •
edited
Loading

Goal

Remove usage of deprecated Rails.applications.secrets

Deprecation warning on CI

DEPRECATION WARNING: `Rails.application.secrets` is deprecated in favor of `Rails.application.credentials` and will be removed in Rails 7.2. (called from secrets at /Users/hac/.rvm/gems/ruby-3.2.2@railsdevs.com/gems/pay-6.6.1/lib/pay/env.rb:43)

@excid3
Copy link
Collaborator

excid3 commented Jul 17, 2023

We still need this in order to support older Rails applications.

@excid3 excid3 closed this Jul 17, 2023
@excid3 excid3 reopened this Jul 17, 2023
excid3
excid3 requested changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@excid3 excid3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, closed this on accident.

Let's include Rails secrets if the app is on 7.1 or lower. We don't want to break existing applications.

lib/pay/env.rb Show resolved Hide resolved
@heliocola heliocola force-pushed the deprecated_rails_app_secrets branch from fe4cba6 to c551416 Compare July 18, 2023 08:06
@heliocola heliocola marked this pull request as draft July 18, 2023 08:10
@heliocola heliocola force-pushed the deprecated_rails_app_secrets branch from d223a35 to 8578c43 Compare July 18, 2023 08:38
@heliocola heliocola marked this pull request as ready for review July 18, 2023 08:38
@heliocola
Copy link
Contributor Author

After a few back and forth I think I've got to a point that this is ready for review! :-)

excid3
excid3 reviewed Jul 18, 2023
View reviewed changes
lib/pay/env.rb Outdated Show resolved Hide resolved
@excid3 excid3 merged commit 480691e into pay-rails:master Jul 18, 2023
@excid3
Copy link
Collaborator

excid3 commented Jul 18, 2023

Thanks very much @heliocola!! 👍

@heliocola heliocola deleted the deprecated_rails_app_secrets branch July 19, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@excid3 excid3 excid3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heliocola @excid3