PAYARA-4197 Always print rollback+timeout warning #4323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- print warning about timeout also in a case when there is more serious error if the tx timeouted too, - when some bean tried to use timeouted transacion, a non-checked exception was thrown and it shadowed the original cause of rollback - the warning wasn't printed then. Now it is.
|
Jenkins test please |
pdudits
approved these changes
Nov 14, 2019
jGauravGupta
approved these changes
Nov 14, 2019
jbee
approved these changes
Nov 14, 2019
dmatej
deleted the
PAYARA-4197-print-timeout-warnings-also-for-exceptions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
was thrown and it shadowed the original cause of rollback - the warning
wasn't printed then. Now it is.
Important Info
Dependant PRs
TBD (there will be done)
Testing
New tests
See future push in #4263 with integrated test case.
Testing Performed
Manual using the JIRA example.
Test suites executed
None of following yet:
Notes for Reviewers
The solution was designed after refactoring done in another PR, because present logging is not much useful and is rather confusing. But refactoring might introduce new errors and will need to pass at least TCK/EJB and TCK/JTA tests. So I created this minimal PR and the refactoring PR will follow.