FISH-786: Support both MP 3.3. and 4.0+ in OSGi #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't export MP packages. Allow to import MP Config from version 1.4 (MP 3.3) to 2.0+ (MP 4.0+) This is needed to integrate to the latest Payara Enterprise
pdudits
reviewed
Jun 28, 2021
openid/pom.xml
Outdated
Comment on lines
134
to
135
| *;resolution:=optional, org.eclipse.microprofile.config;v | ||
| ersion="[1.0,3)" |
There was a problem hiding this comment.
Oh, the end of the line was too heavy and it dropped ;)
There was a problem hiding this comment.
I missed that. I'll these on the same line.
oauth2/pom.xml
Outdated
Comment on lines
94
to
104
| <Import-Package> | ||
| !org.eclipse.microprofile.*, | ||
| org.eclipse.microprofile.config;version="[1.0,3)", | ||
| * | ||
| </Import-Package> | ||
| <Export-Package> | ||
| !org.eclipse.microprofile.*, | ||
| fish.payara.security.oauth2.* | ||
| </Export-Package> | ||
| </instructions> | ||
| <excludeDependencies>microprofile,microprofile-config-api</excludeDependencies> |
There was a problem hiding this comment.
Are all of these necessary? In theory only * and the rule for config package should be necessary, and only for imports.
Exports and excludeDependencies are not needed (I didn't try though).
There was a problem hiding this comment.
You're right. In the end it's enough to place the config package in import before the microprofile and * imports. When I added it to the end of the list, it was being ignored because the packages were handled by the previous rules.
OndroMih
force-pushed
the
fish-786-enterprise
branch
from
d622030
to
4485170
Compare
pdudits
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't export MP packages. Allow to import MP Config
from version 1.4 (MP 3.3) to 2.0+ (MP 4.0+)
This is needed to integrate to the latest Payara Enterprise.