Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FISH-786 Split api into its own jar for distribution #81

Merged
merged 2 commits into from
Apr 15, 2021
Merged

FISH-786 Split api into its own jar for distribution #81

merged 2 commits into from
Apr 15, 2021

Conversation

Cousjava
Copy link
Contributor

No description provided.

@Cousjava Cousjava requested a review from pdudits April 14, 2021 14:21
pdudits
pdudits approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@pdudits pdudits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd definitely try how this affect standalone, but there's internet outage and I cannot do that on my phone 🙄

security-api/pom.xml Outdated
</parent>

<groupId>fish.payara.security.connectors</groupId>
<artifactId>security-api</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably go for security-connectors-api, Security sound too broad

@pdudits
Copy link
Contributor

pdudits commented Apr 14, 2021

I'd definitely try how this affect standalone

Tried that, everything works.

@Cousjava Cousjava merged commit f821c25 into payara:master Apr 15, 2021
@jGauravGupta jGauravGupta added this to the 2.0.0.beta1 milestone May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdudits pdudits pdudits approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0.beta1
Development

Successfully merging this pull request may close these issues.
3 participants
@Cousjava @pdudits @jGauravGupta