Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Extract service module into payavel/orchestration package. #36

Merged
merged 54 commits into from
Apr 19, 2024

Conversation

r-kujawa
Copy link
Contributor

@r-kujawa r-kujawa commented May 17, 2023

What does this PR do? 🤖

It extracts foundational code to be reused within multiple Payavel packages (checkout, subscriptions and future reporting packages).

Does this relate to any issue? 🔗

Closes #26

@r-kujawa r-kujawa changed the title 🚧 Extract service module into payavel/service package. 🚧 [1.x] Extract service module into payavel/service package. May 17, 2023
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Attention: Patch coverage is 46.34146% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 26.84%. Comparing base (3a4db97) to head (ff225d3).

Files Patch % Lines
src/Models/PaymentMethod.php 28.57% 5 Missing ⚠️
src/Models/PaymentTransaction.php 28.57% 5 Missing ⚠️
src/Models/Wallet.php 33.33% 4 Missing ⚠️
src/Models/PaymentTransactionEvent.php 0.00% 3 Missing ⚠️
src/Models/Traits/ConfiguresPaymentGateway.php 0.00% 2 Missing ⚠️
src/PaymentResponse.php 0.00% 2 Missing ⚠️
src/Models/PaymentType.php 66.66% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master      #36       +/-   ##
=============================================
- Coverage     67.13%   26.84%   -40.29%     
+ Complexity      223       67      -156     
=============================================
  Files            42       17       -25     
  Lines           712      149      -563     
=============================================
- Hits            478       40      -438     
+ Misses          234      109      -125     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r-kujawa r-kujawa force-pushed the enhancement-26-extract_service branch from b016977 to 8554f8c Compare June 10, 2023 14:41
@r-kujawa r-kujawa changed the base branch from 1.x to master August 10, 2023 16:17
@r-kujawa r-kujawa force-pushed the enhancement-26-extract_service branch from 48b9d28 to dcc2902 Compare August 14, 2023 18:54
@r-kujawa r-kujawa changed the title 🚧 [1.x] Extract service module into payavel/service package. 🚧 [2.x] Extract service module into payavel/service package. Aug 14, 2023
@r-kujawa r-kujawa changed the title 🚧 [2.x] Extract service module into payavel/orchestration package. [2.x] Extract service module into payavel/orchestration package. Apr 17, 2024
@r-kujawa r-kujawa merged commit a41aa90 into master Apr 19, 2024
5 of 7 checks passed
@r-kujawa r-kujawa deleted the enhancement-26-extract_service branch April 19, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract the service foundation into a separate package.
1 participant