Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Fix undefined relations to provider & merchant while using config driver. #37

Merged
merged 16 commits into from
May 23, 2023

Conversation

r-kujawa
Copy link
Contributor

@r-kujawa r-kujawa commented May 23, 2023

What does this PR do? 🤖

  • Allows for gateway requests to be auto-configured within the Wallet::class & PaymentMethod::class models using any driver.
  • Improves code coverage by adding and reorganizing tests.

Any background context you would like to provide? 🚧

This bug was introduced when we added support from only database drivers to custom drivers, including the config driver.

Does this relate to any issue? 🔗

Closes #34

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +3.33 🎉

Comparison is base (8856202) 56.13% compared to head (3fea79f) 59.46%.

Additional details and impacted files
@@             Coverage Diff              @@
##                1.x      #37      +/-   ##
============================================
+ Coverage     56.13%   59.46%   +3.33%     
- Complexity      224      226       +2     
============================================
  Files            42       42              
  Lines           709      713       +4     
============================================
+ Hits            398      424      +26     
+ Misses          311      289      -22     
Impacted Files Coverage Δ
src/Models/PaymentMethod.php 50.00% <100.00%> (+33.33%) ⬆️
src/Models/Traits/ConfiguresPaymentGateway.php 100.00% <100.00%> (+100.00%) ⬆️
src/database/factories/PaymentProviderFactory.php 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@r-kujawa r-kujawa changed the title 🚧 Fix undefined relations to provider & merchant while using config driver. 🚧 [1.x] Fix undefined relations to provider & merchant while using config driver. May 23, 2023
@r-kujawa r-kujawa changed the title 🚧 [1.x] Fix undefined relations to provider & merchant while using config driver. [1.x] Fix undefined relations to provider & merchant while using config driver. May 23, 2023
@r-kujawa r-kujawa merged commit a306b8b into 1.x May 23, 2023
@r-kujawa r-kujawa deleted the bug-34-config_driver_relations branch May 23, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wallet::class model suposses we are using database driver to retrieve provider & merchant.
1 participant