Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go言語サポートバージョンの更新 & fix lint #12

Merged
merged 1 commit into from
Jun 24, 2019

Conversation

darai0512
Copy link
Contributor

@darai0512 darai0512 commented Jun 24, 2019

abstract

golangのサポートバージョンを更新する

  • stable: https://golang.org/dl/
  • go get golang.org がサポートしている1.9以上を目安にサポート

fix the following lint errors.

  • comment on exported method ... should be of the form ...
  • error strings should not be capitalized or end with punctuation or a newline
  • don't use underscores in Go names; var set_subscr should be setSubscr

check

  • pass lint
  • pass tests

@darai0512 darai0512 self-assigned this Jun 24, 2019
@darai0512 darai0512 force-pushed the fix-lint-master branch 2 times, most recently from 33378c7 to 33462df Compare June 24, 2019 08:53
@darai0512 darai0512 changed the title fix lint & CIでのlint checkを復活 Go言語サポートバージョンの更新 & fix lint Jun 24, 2019
Copy link

@flagboy flagboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

変更とても良いですね

@darai0512 darai0512 merged commit dd9956d into master Jun 24, 2019
@darai0512 darai0512 deleted the fix-lint-master branch June 24, 2019 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants