Skip to content

Commit 209b1f1

Browse files
authored
chore(eslint): set reportUnusedDisableDirectives to error (#14011)
Sets `reportUnusedDisableDirectives: 'error'` in our eslint config. This will error when `// eslint-disable-*` directives are unused. It will also auto-fix if possible.
1 parent de352a6 commit 209b1f1

File tree

6 files changed

+6
-7
lines changed

6 files changed

+6
-7
lines changed

packages/eslint-config/index.mjs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -181,6 +181,9 @@ export const rootEslintConfig = [
181181
},
182182
parser: typescriptParser,
183183
},
184+
linterOptions: {
185+
reportUnusedDisableDirectives: 'error',
186+
},
184187
plugins: {
185188
'import-x': importX,
186189
},

packages/next/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@
8181
"build:swc": "swc ./src -d ./dist --config-file .swcrc --strip-leading-paths",
8282
"build:types": "tsc --emitDeclarationOnly --outDir dist",
8383
"build:without_reactcompiler": "rm -rf dist && rm -rf tsconfig.tsbuildinfo && pnpm copyfiles && pnpm build:types && pnpm build:swc && pnpm build:cjs && pnpm build:esbuild",
84-
"clean": "rimraf -g {dist,*.tsbuildinfo}",
84+
"clean": "rimraf -g {dist,*.tsbuildinfo,esbuild}",
8585
"copyfiles": "copyfiles -u 1 \"src/**/*.{html,css,scss,ttf,woff,woff2,eot,svg,jpg,png,json}\" dist/",
8686
"lint": "eslint .",
8787
"lint:fix": "eslint . --fix",

packages/richtext-lexical/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,7 @@
350350
"build:swc": "swc ./src -d ./dist --config-file .swcrc --strip-leading-paths",
351351
"build:types": "tsc --emitDeclarationOnly --outDir dist",
352352
"build:without_reactcompiler": "rm -rf dist && rm -rf tsconfig.tsbuildinfo && pnpm copyfiles && pnpm build:types && pnpm build:swc && pnpm build:esbuild && pnpm build:esbuild:postproces && rm -rf dist/exports/client && mv dist/exports/client_unoptimized dist/exports/client",
353-
"clean": "rimraf -g {dist,*.tsbuildinfo}",
353+
"clean": "rimraf -g {dist,*.tsbuildinfo,esbuild}",
354354
"copyfiles": "copyfiles -u 1 \"src/**/*.{html,css,ttf,woff,woff2,eot,svg,jpg,png,json}\" dist/",
355355
"lint": "eslint .",
356356
"lint:fix": "eslint . --fix",

packages/ui/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@
129129
"build:swc": "swc ./src -d dist --config-file .swcrc --strip-leading-paths",
130130
"build:types": "tsc --emitDeclarationOnly --outDir dist",
131131
"build:without_reactcompiler": "rm -rf dist && rm -rf tsconfig.tsbuildinfo && pnpm copyfiles && pnpm build:types && pnpm build:swc",
132-
"clean": "rimraf -g {dist,*.tsbuildinfo}",
132+
"clean": "rimraf -g {dist,*.tsbuildinfo,esbuild}",
133133
"copyfiles": "copyfiles -u 1 \"src/**/*.{html,css,scss,ttf,woff,woff2,eot,svg,jpg,png,json}\" dist/",
134134
"lint": "eslint .",
135135
"lint:fix": "eslint . --fix",

packages/ui/src/providers/Preferences/index.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -157,11 +157,8 @@ export const PreferencesProvider: React.FC<{ children?: React.ReactNode }> = ({
157157
[api, getPreference, i18n.language, pendingUpdate, serverURL],
158158
)
159159

160-
// eslint-disable-next-line react-compiler/react-compiler -- TODO: fix
161160
contextRef.current.getPreference = getPreference
162-
// eslint-disable-next-line react-compiler/react-compiler -- TODO: fix
163161
contextRef.current.setPreference = setPreference
164-
// eslint-disable-next-line react-compiler/react-compiler -- TODO: fix
165162
return <Context value={contextRef.current}>{children}</Context>
166163
}
167164

packages/ui/src/providers/TableColumns/index.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,6 @@ export const TableColumnsProvider: React.FC<TableColumnsProviderProps> = ({
100100
resetColumnsState,
101101
setActiveColumns,
102102
toggleColumn,
103-
// eslint-disable-next-line react-compiler/react-compiler
104103
...contextRef.current,
105104
}}
106105
>

0 commit comments

Comments
 (0)