Skip to content

Commit 332b2a9

Browse files
authored
fix(ui): double ? in gravatar url (#13511)
### What? Ensure the Gravatar URL appends the query string only once. ### Why? Previously `src` used `...?${query}` while `query` already began with `?`, producing `??` and causing the avatar URL to be invalid in some cases. ### How? - Keep `query` as `?${params}` (from `URLSearchParams`). - Change `src` from `https://www.gravatar.com/avatar/${hash}?${query}` to `https://www.gravatar.com/avatar/${hash}${query}` so only one `?` is present. Fixes #13325
1 parent 92d459e commit 332b2a9

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

packages/ui/src/graphics/Account/Gravatar/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export const GravatarAccountIcon: React.FC = () => {
2222
alt="yas"
2323
className="gravatar-account"
2424
height={25}
25-
src={`https://www.gravatar.com/avatar/${hash}?${query}`}
25+
src={`https://www.gravatar.com/avatar/${hash}${query}`}
2626
style={{ borderRadius: '50%' }}
2727
width={25}
2828
/>

packages/ui/src/graphics/Account/index.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import { usePathname } from 'next/navigation.js'
33
import { formatAdminURL } from 'payload/shared'
44
import React from 'react'
55

6-
// import { RenderComponent } from '../../elements/RenderComponent/client.js'
76
import { useAuth } from '../../providers/Auth/index.js'
87
import { useConfig } from '../../providers/Config/index.js'
98
import { DefaultAccountIcon } from './Default/index.js'

0 commit comments

Comments
 (0)