chore: fix various e2e test setup issues (#12670)

I noticed a few issues when running e2e tests that will be resolved by
this PR:

- Most important: for some test suites (fields, fields-relationship,
versions, queues, lexical), the database was cleared and seeded
**twice** in between each test run. This is because the onInit function
was running the clear and seed script, when it should only have been
running the seed script. Clearing the database / the snapshot workflow
is being done by the reInit endpoint, which then calls onInit to seed
the actual data.
- The slowest part of `clearAndSeedEverything` is recreating indexes on
mongodb. This PR slightly improves performance here by:
- Skipping this process for the built-in `['payload-migrations',
'payload-preferences', 'payload-locked-documents']` collections
- Previously we were calling both `createIndexes` and `ensureIndexes`.
This was unnecessary - `ensureIndexes` is a deprecated alias of
`createIndexes`. This PR changes it to only call `createIndexes`
- Makes the reinit endpoint accept GET requests instead of POST requests
- this makes it easier to debug right in the browser
- Some typescript fixes
- Adds a `dev:memorydb` script to the package.json. For some reason,
`dev` is super unreliable on mongodb locally when running e2e tests - it
frequently fails during index creation. Using the memorydb fixes this
issue, with the bonus of more closely resembling the CI environment
- Previously, you were unable to run test suites using turbopack +
postgres. This fixes it, by explicitly installing `pg` as devDependency
in our monorepo
- Fixes jest open handles warning

Author: AlessioGr

package.json

@@ -65,6 +65,7 @@
     "dev:generate-graphql-schema": "pnpm runts ./test/generateGraphQLSchema.ts",
     "dev:generate-importmap": "pnpm runts ./test/generateImportMap.ts",
     "dev:generate-types": "pnpm runts ./test/generateTypes.ts",
+    "dev:memorydb": "cross-env NODE_OPTIONS=--no-deprecation tsx ./test/dev.ts --start-memory-db",
     "dev:postgres": "cross-env PAYLOAD_DATABASE=postgres pnpm runts ./test/dev.ts",
     "dev:prod": "cross-env NODE_OPTIONS=--no-deprecation tsx ./test/dev.ts --prod",
     "dev:prod:memorydb": "cross-env NODE_OPTIONS=--no-deprecation tsx ./test/dev.ts --prod --start-memory-db",
@@ -155,10 +156,11 @@
     "jest": "29.7.0",
     "lint-staged": "15.2.7",
     "minimist": "1.2.8",
-    "mongodb-memory-server": "^10",
+    "mongodb-memory-server": "10.1.4",
     "next": "15.3.2",
     "open": "^10.1.0",
     "p-limit": "^5.0.0",
+    "pg": "8.11.3",
     "playwright": "1.50.0",
     "playwright-core": "1.50.0",
     "prettier": "3.5.3",

packages/db-mongodb/package.json

@@ -17,8 +17,8 @@
       "url": "https://payloadcms.com"
     }
   ],
-  "type": "module",
   "sideEffects": false,
+  "type": "module",
   "exports": {
     ".": {
       "import": "./src/index.ts",
@@ -58,7 +58,7 @@
     "@types/prompts": "^2.4.5",
     "@types/uuid": "10.0.0",
     "mongodb": "6.12.0",
-    "mongodb-memory-server": "^10",
+    "mongodb-memory-server": "10.1.4",
     "payload": "workspace:*"
   },
   "peerDependencies": {

packages/db-mongodb/src/connect.ts

@@ -40,6 +40,9 @@ export const connect: Connect = async function connect(
     // If we are running a replica set with MongoDB Memory Server,
     // wait until the replica set elects a primary before proceeding
     if (this.mongoMemoryServer) {
+      this.payload.logger.info(
+        'Waiting for MongoDB Memory Server replica set to elect a primary...',
+      )
       await new Promise((resolve) => setTimeout(resolve, 2000))
     }
 
@@ -50,7 +53,7 @@ export const connect: Connect = async function connect(
       this.beginTransaction = defaultBeginTransaction()
     }
 
-    if (!this.mongoMemoryServer && !hotReload) {
+    if (!hotReload) {
       if (process.env.PAYLOAD_DROP_DATABASE === 'true') {
         this.payload.logger.info('---- DROPPING DATABASE ----')
         await mongoose.connection.dropDatabase()

packages/db-mongodb/src/destroy.ts

@@ -5,11 +5,7 @@ import mongoose from 'mongoose'
 import type { MongooseAdapter } from './index.js'
 
 export const destroy: Destroy = async function destroy(this: MongooseAdapter) {
-  if (this.mongoMemoryServer) {
-    await this.mongoMemoryServer.stop()
-  } else {
-    await mongoose.disconnect()
-  }
+  await mongoose.disconnect()
 
   Object.keys(mongoose.models).map((model) => mongoose.deleteModel(model))
 }

pnpm-lock.yaml

@@ -63,7 +63,7 @@
     "eslint": "^9.23.0",
     "eslint-config-next": "15.3.0",
     "graphql": "^16.8.1",
-    "mongodb-memory-server": "^10.1.2",
+    "mongodb-memory-server": "10.1.4",
     "next": "15.3.0",
     "open": "^10.1.0",
     "payload": "3.37.0",

templates/plugin/package.json

@@ -2,9 +2,7 @@ import type { Payload } from 'payload'
 
 import { devUser } from '../credentials.js'
 import { executePromises } from '../helpers/executePromises.js'
-import { seedDB } from '../helpers/seed.js'
 import {
-  collectionSlugs,
   customViews1CollectionSlug,
   customViews2CollectionSlug,
   geoCollectionSlug,
@@ -14,7 +12,7 @@ import {
   with300DocumentsSlug,
 } from './slugs.js'
 
-export const seed = async (_payload) => {
+export const seed = async (_payload: Payload) => {
   await executePromises(
     [
       () =>
@@ -139,12 +137,3 @@ export const seed = async (_payload) => {
 
   await Promise.all([...manyDocumentsPromises])
 }
-
-export async function clearAndSeedEverything(_payload: Payload) {
-  return await seedDB({
-    _payload,
-    collectionSlugs,
-    seedFunction: seed,
-    snapshotKey: 'adminTests',
-  })
-}

test/admin/seed.ts

@@ -32,7 +32,7 @@ import { es } from 'payload/i18n/es'
 import sharp from 'sharp'
 
 import { databaseAdapter } from './databaseAdapter.js'
-import { reInitEndpoint } from './helpers/reInit.js'
+import { reInitEndpoint } from './helpers/reInitEndpoint.js'
 import { localAPIEndpoint } from './helpers/sdk/endpoint.js'
 import { testEmailAdapter } from './testEmailAdapter.js'
 

test/buildConfigWithDefaults.ts

@@ -18,7 +18,7 @@ import { Restricted } from './collections/Restricted/index.js'
 import { RelationshipUpdatedExternally } from './collections/UpdatedExternally/index.js'
 import { Versions } from './collections/Versions/index.js'
 import { Video } from './collections/Video/index.js'
-import { clearAndSeedEverything } from './seed.js'
+import { seed } from './seed.js'
 
 export default buildConfigWithDefaults({
   admin: {
@@ -49,7 +49,7 @@ export default buildConfigWithDefaults({
   },
   onInit: async (payload) => {
     if (process.env.SEED_IN_CONFIG_ONINIT !== 'false') {
-      await clearAndSeedEverything(payload)
+      await seed(payload)
     }
   },
   typescript: {

test/fields-relationship/config.ts

@@ -1,14 +1,9 @@
 import type { Payload } from 'payload'
 
-import path from 'path'
-import { fileURLToPath } from 'url'
-
 import { devUser } from '../credentials.js'
-import { seedDB } from '../helpers/seed.js'
 import {
   collection1Slug,
   collection2Slug,
-  collectionSlugs,
   podcastCollectionSlug,
   relationOneSlug,
   relationRestrictedSlug,
@@ -18,9 +13,6 @@ import {
   videoCollectionSlug,
 } from './slugs.js'
 
-const filename = fileURLToPath(import.meta.url)
-const dirname = path.dirname(filename)
-
 export const seed = async (_payload: Payload) => {
   await _payload.create({
     collection: 'users',
@@ -179,13 +171,3 @@ export const seed = async (_payload: Payload) => {
     })
   }
 }
-
-export async function clearAndSeedEverything(_payload: Payload) {
-  return await seedDB({
-    _payload,
-    collectionSlugs,
-    seedFunction: seed,
-    snapshotKey: 'fieldsTest',
-    uploadsDir: path.resolve(dirname, './collections/Upload/uploads'),
-  })
-}