fix(richtext-lexical): incorrect table action menu placement (#10627)

rilrom · web-flow · commit 9684d3165ee7 · 2025-01-20T19:37:43.000-03:00
Fixes #10626 This was originally fixed in this [lexical PR](facebook/lexical#4301), however it seems both the `TypeAheadMenu` plugin and the `TableActionMenu` plugin are broken in lexical playground again. I was unable to find any issues with the `SlashMenu` in our case so I left it as is. ## Before https://github.com/user-attachments/assets/5f8287a2-2875-4eb5-9402-933b0ce30af5 ## After https://github.com/user-attachments/assets/44394923-3dd8-4fd7-9d58-2c29886490e6
diff --git a/packages/richtext-lexical/src/features/experimental_table/client/plugins/TableActionMenuPlugin/index.tsx b/packages/richtext-lexical/src/features/experimental_table/client/plugins/TableActionMenuPlugin/index.tsx
@@ -175,7 +175,7 @@ function TableActionMenu({
       let topPosition = menuButtonRect.top
       if (topPosition + dropDownElementRect.height > window.innerHeight) {
         const position = menuButtonRect.bottom - dropDownElementRect.height
-        topPosition = (position < 0 ? margin : position) + window.pageYOffset
+        topPosition = position < 0 ? margin : position
       }
       dropDownElement.style.top = `${topPosition}px`
     }

Original file line number	Diff line number	Diff line change
`@@ -175,7 +175,7 @@ function TableActionMenu({`
`175`	`175`	`let topPosition = menuButtonRect.top`
`176`	`176`	`if (topPosition + dropDownElementRect.height > window.innerHeight) {`
`177`	`177`	`const position = menuButtonRect.bottom - dropDownElementRect.height`
`178`		`- topPosition = (position < 0 ? margin : position) + window.pageYOffset`
	`178`	`+ topPosition = position < 0 ? margin : position`
`179`	`179`	`}`
`180`	`180`	dropDownElement.style.top = `${topPosition}px`
`181`	`181`	`}`