Skip to content

Commit a68f0ce

Browse files
authored
fix(ui): nav button height being stretched and navWrapper border on RTL (#8242)
1 parent 8520fd9 commit a68f0ce

File tree

4 files changed

+21
-4
lines changed

4 files changed

+21
-4
lines changed

packages/next/src/elements/Nav/NavWrapper/index.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,11 @@
1010
border-right: 1px solid var(--theme-elevation-100);
1111
opacity: 0;
1212

13+
[dir='rtl'] & {
14+
border-right: none;
15+
border-left: 1px solid var(--theme-elevation-100);
16+
}
17+
1318
&--nav-animate {
1419
transition: opacity var(--nav-trans-time) ease-in-out;
1520
}

packages/next/src/elements/Nav/index.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,11 @@
1111
opacity: 0;
1212
overflow: hidden;
1313

14+
[dir='rtl'] & {
15+
border-right: none;
16+
border-left: 1px solid var(--theme-elevation-100);
17+
}
18+
1419
&--nav-animate {
1520
transition: opacity var(--nav-trans-time) ease-in-out;
1621
}

packages/next/src/templates/Default/index.scss

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,17 @@
2020
justify-content: center;
2121
}
2222

23-
&__nav-toggler {
23+
&__nav-toggler-container {
2424
height: var(--app-header-height);
2525
display: flex;
2626
align-items: center;
2727
}
2828

29+
&__nav-toggler {
30+
display: flex;
31+
align-items: center;
32+
}
33+
2934
&__wrap {
3035
min-width: 0;
3136
width: 100%;

packages/next/src/templates/Default/index.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,11 @@ export const DefaultTemplate: React.FC<DefaultTemplateProps> = ({
7171
<RenderComponent mappedComponent={MappedCustomHeader} />
7272
<div style={{ position: 'relative' }}>
7373
<div className={`${baseClass}__nav-toggler-wrapper`} id="nav-toggler">
74-
<NavToggler className={`${baseClass}__nav-toggler`}>
75-
<NavHamburger />
76-
</NavToggler>
74+
<div className={`${baseClass}__nav-toggler-container`} id="nav-toggler">
75+
<NavToggler className={`${baseClass}__nav-toggler`}>
76+
<NavHamburger />
77+
</NavToggler>
78+
</div>
7779
</div>
7880
<Wrapper baseClass={baseClass} className={className}>
7981
<RenderComponent mappedComponent={MappedDefaultNav} />

0 commit comments

Comments
 (0)