chore(plugin-cloud-storage): enable TypeScript strict (#11850)

Author: GermanJablo

packages/plugin-cloud-storage/src/admin/fields/getFields.ts

@@ -88,11 +88,11 @@ export const getFields = ({ collection, prefix }: Args): Field[] => {
           type: 'group',
           fields: [
             {
-              ...(existingSizeURLField || ({} as any)),
+              ...(existingSizeURLField || {}),
               ...baseURLField,
             },
           ],
-        }
+        } as Field
       }),
     }
 

packages/plugin-cloud-storage/src/fields/getFields.ts

@@ -108,7 +108,7 @@ export const getFields = ({
           fields: [
             ...(adapter.fields || []),
             {
-              ...(existingSizeURLField || ({} as any)),
+              ...(existingSizeURLField || {}),
               ...baseURLField,
               hooks: {
                 afterRead: [
@@ -124,7 +124,7 @@ export const getFields = ({
               },
             },
           ],
-        }
+        } as Field
       }),
     }
 

packages/plugin-cloud-storage/src/hooks/afterDelete.ts

@@ -15,7 +15,9 @@ export const getAfterDeleteHook = ({
     try {
       const filesToDelete: string[] = [
         doc.filename,
-        ...Object.values(doc?.sizes || []).map((resizedFileData) => resizedFileData?.filename),
+        ...Object.values(doc?.sizes || []).map(
+          (resizedFileData) => resizedFileData?.filename as string,
+        ),
       ]
 
       const promises = filesToDelete.map(async (filename) => {

packages/plugin-cloud-storage/src/hooks/afterRead.ts

@@ -18,7 +18,7 @@ export const getAfterReadHook =
     let url = value
 
     if (disablePayloadAccessControl && filename) {
-      url = await adapter.generateURL({
+      url = await adapter.generateURL?.({
         collection,
         data,
         filename,

packages/plugin-cloud-storage/src/hooks/beforeChange.ts

@@ -29,7 +29,7 @@ export const getBeforeChangeHook =
           if (typeof originalDoc.sizes === 'object') {
             filesToDelete = filesToDelete.concat(
               Object.values(originalDoc?.sizes || []).map(
-                (resizedFileData) => resizedFileData?.filename,
+                (resizedFileData) => resizedFileData?.filename as string,
               ),
             )
           }

packages/plugin-cloud-storage/src/plugin.ts

@@ -67,9 +67,6 @@ export const cloudStoragePlugin =
               if ('clientUploadContext' in args.params) {
                 return adapter.staticHandler(req, args)
               }
-
-              // Otherwise still skip staticHandler
-              return null
             })
           }
 

packages/plugin-cloud-storage/src/utilities/initClientUploads.ts

@@ -89,7 +89,7 @@ export const initClientUploads = <ExtraProps extends Record<string, unknown>, T>
       clientProps: {
         collectionSlug,
         enabled,
-        extra: extraClientHandlerProps ? extraClientHandlerProps(collection) : undefined,
+        extra: extraClientHandlerProps ? extraClientHandlerProps(collection!) : undefined,
         prefix,
         serverHandlerPath,
       },

packages/plugin-cloud-storage/tsconfig.json

@@ -1,9 +1,4 @@
 {
   "extends": "../../tsconfig.base.json",
-  "compilerOptions": {
-    /* TODO: remove the following lines */
-    "strict": false,
-    "noUncheckedIndexedAccess": false,
-  },
   "references": [{ "path": "../payload" }, { "path": "../ui" }]
 }