fix!: handle custom id logic in mongodb adapter (#9069)

### What?
Moved the logic for copying the data.id to data._id to the mongoose
adapter.

### Why?
If you have any hooks that need to set the `id`, the value does not get
sent to mongodb as you would expect since it was copied before the
beforeValidate hooks.

### How?
Now data._id is assigned only in the mongodb adapter's `create`
function.

BREAKING CHANGES:
When using custom ID fields, if you have any collection hooks for
beforeValidate, beforeChange then `data._id` will no longer be assigned
as this happens now in the database adapter. Use `data.id` instead.

Author: DanRibbens

docs/fields/overview.mdx

@@ -356,7 +356,7 @@ For full details on Admin Options, see the [Field Admin Options](../admin/fields
 
 ## Custom ID Fields
 
-All [Collections](../configuration/collections) automatically generate their own ID field. If needed, you can override this behavior by providing an explicit ID field to your config. This will force users to provide a their own ID value when creating a record.
+All [Collections](../configuration/collections) automatically generate their own ID field. If needed, you can override this behavior by providing an explicit ID field to your config. This field should either be required or have a hook to generate the ID dynamically.
 
 To define a custom ID field, add a new field with the `name` property set to `id`:
 
@@ -368,6 +368,7 @@ export const MyCollection: CollectionConfig = {
   fields: [
     {
       name: 'id', // highlight-line
+      required: true,
       type: 'number',
     },
   ],

packages/db-mongodb/src/create.ts

@@ -20,6 +20,10 @@ export const create: Create = async function create(
     fields: this.payload.collections[collection].config.fields,
   })
 
+  if (this.payload.collections[collection].customIDType) {
+    sanitizedData._id = sanitizedData.id
+  }
+
   try {
     ;[doc] = await Model.create([sanitizedData], options)
   } catch (error) {

packages/payload/src/collections/operations/create.ts

@@ -123,17 +123,6 @@ export const createOperation = async <
       await executeAccess({ data, req }, collectionConfig.access.create)
     }
 
-    // /////////////////////////////////////
-    // Custom id
-    // /////////////////////////////////////
-
-    if (payload.collections[collectionConfig.slug].customIDType) {
-      data = {
-        _id: data.id,
-        ...data,
-      }
-    }
-
     // /////////////////////////////////////
     // Generate data for all files and sizes
     // /////////////////////////////////////

test/database/config.ts

@@ -4,6 +4,8 @@ const filename = fileURLToPath(import.meta.url)
 const dirname = path.dirname(filename)
 import type { TextField } from 'payload'
 
+import { v4 as uuid } from 'uuid'
+
 import { buildConfigWithDefaults } from '../buildConfigWithDefaults.js'
 import { devUser } from '../credentials.js'
 
@@ -356,6 +358,29 @@ export default buildConfigWithDefaults({
         },
       ],
     },
+    {
+      slug: 'custom-ids',
+      fields: [
+        {
+          name: 'id',
+          type: 'text',
+          admin: {
+            readOnly: true,
+          },
+          hooks: {
+            beforeChange: [
+              ({ value, operation }) => {
+                if (operation === 'create') {
+                  return uuid()
+                }
+                return value
+              },
+            ],
+          },
+        },
+      ],
+      versions: { drafts: true },
+    },
   ],
   globals: [
     {

test/database/int.spec.ts

@@ -75,10 +75,19 @@ describe('database', () => {
 
       expect(updated.id).toStrictEqual(created.doc.id)
     })
+
+    it('should create with generated ID text from hook', async () => {
+      const doc = await payload.create({
+        collection: 'custom-ids',
+        data: {},
+      })
+
+      expect(doc.id).toBeDefined()
+    })
   })
 
   describe('timestamps', () => {
-    it('should have createdAt and updatedAt timetstamps to the millisecond', async () => {
+    it('should have createdAt and updatedAt timestamps to the millisecond', async () => {
       const result = await payload.create({
         collection: 'posts',
         data: {