fix: error after view is left idle on edit views (#9709)

JarrodMFlesch · web-flow · commit fbb59bab0a63 · 2024-12-03T15:49:07.000-05:00
### What? ![CleanShot 2024-12-03 at 15 00 13](https://github.com/user-attachments/assets/63afb1cf-59ae-4ae7-8741-c98cca0134df) ### Why? `user.id` was being used as a dependency is callbacks and when the user was logged out due to inactivity the above error would throw. ### How? Added optional chaining to the dependency.
diff --git a/packages/next/src/views/LivePreview/index.client.tsx b/packages/next/src/views/LivePreview/index.client.tsx
@@ -256,7 +256,7 @@ const PreviewView: React.FC<Props> = ({
       operation,
       schemaPath,
       setDocumentIsLocked,
-      user.id,
+      user?.id,
       setCurrentEditor,
     ],
   )
diff --git a/packages/ui/src/views/Edit/index.tsx b/packages/ui/src/views/Edit/index.tsx
@@ -233,7 +233,7 @@ export const DefaultEditView: React.FC<ClientSideEditViewProps> = ({
         }
       }
     },
-    [setCurrentEditor, setDocumentIsLocked, user.id],
+    [setCurrentEditor, setDocumentIsLocked, user?.id],
   )
 
   const onSave = useCallback(

Original file line number	Diff line number	Diff line change
`@@ -256,7 +256,7 @@ const PreviewView: React.FC<Props> = ({`
`256`	`256`	`operation,`
`257`	`257`	`schemaPath,`
`258`	`258`	`setDocumentIsLocked,`
`259`		`- user.id,`
	`259`	`+ user?.id,`
`260`	`260`	`setCurrentEditor,`
`261`	`261`	`],`
`262`	`262`	`)`
Original file line number	Diff line number	Diff line change
`@@ -233,7 +233,7 @@ export const DefaultEditView: React.FC<ClientSideEditViewProps> = ({`
`233`	`233`	`}`
`234`	`234`	`}`
`235`	`235`	`},`
`236`		`- [setCurrentEditor, setDocumentIsLocked, user.id],`
	`236`	`+ [setCurrentEditor, setDocumentIsLocked, user?.id],`
`237`	`237`	`)`
`238`	`238`
`239`	`239`	`const onSave = useCallback(`