chore(plugin-nested-docs): enable TypeScript strict (#11930)

Author: GermanJablo

packages/plugin-nested-docs/src/fields/parentFilterOptions.ts

@@ -10,5 +10,5 @@ export const parentFilterOptions: (breadcrumbsFieldSlug?: string) => FilterOptio
       }
     }
 
-    return null
+    return true
   }

packages/plugin-nested-docs/src/hooks/resaveChildren.ts

@@ -58,9 +58,11 @@ const resave = async ({ collection, doc, draft, pluginConfig, req }: ResaveArgs)
       },
     })
 
-    const childrenById = [...draftChildren, ...publishedChildren.docs].reduce((acc, child) => {
+    const childrenById = [...draftChildren, ...publishedChildren.docs].reduce<
+      Record<string, JsonObject[]>
+    >((acc, child) => {
       acc[child.id] = acc[child.id] || []
-      acc[child.id].push(child)
+      acc[child.id]!.push(child)
       return acc
     }, {})
 

packages/plugin-nested-docs/src/hooks/resaveSelfAfterCreate.ts

@@ -1,6 +1,6 @@
 import type { CollectionAfterChangeHook, CollectionConfig } from 'payload'
 
-import type { NestedDocsPluginConfig } from '../types.js'
+import type { Breadcrumb, NestedDocsPluginConfig } from '../types.js'
 
 // This hook automatically re-saves a document after it is created
 // so that we can build its breadcrumbs with the newly created document's ID.
@@ -10,7 +10,7 @@ export const resaveSelfAfterCreate =
   async ({ doc, operation, req }) => {
     const { locale, payload } = req
     const breadcrumbSlug = pluginConfig.breadcrumbsFieldSlug || 'breadcrumbs'
-    const breadcrumbs = doc[breadcrumbSlug]
+    const breadcrumbs = doc[breadcrumbSlug] as unknown as Breadcrumb[]
 
     if (operation === 'create') {
       const originalDocWithDepth0 = await payload.findByID({

packages/plugin-nested-docs/src/utilities/formatBreadcrumb.ts

@@ -10,7 +10,7 @@ export const formatBreadcrumb = (
   let url: string | undefined = undefined
   let label: string
 
-  const lastDoc = docs[docs.length - 1]
+  const lastDoc = docs[docs.length - 1]!
 
   if (typeof pluginConfig?.generateURL === 'function') {
     url = pluginConfig.generateURL(docs, lastDoc)
@@ -19,7 +19,7 @@ export const formatBreadcrumb = (
   if (typeof pluginConfig?.generateLabel === 'function') {
     label = pluginConfig.generateLabel(docs, lastDoc)
   } else {
-    const title = lastDoc[collection.admin.useAsTitle]
+    const title = collection.admin?.useAsTitle ? lastDoc[collection.admin.useAsTitle] : ''
 
     label = typeof title === 'string' || typeof title === 'number' ? String(title) : ''
   }

packages/plugin-nested-docs/src/utilities/getParents.ts

@@ -11,7 +11,7 @@ export const getParents = async (
 ): Promise<Array<Record<string, unknown>>> => {
   const parentSlug = pluginConfig?.parentFieldSlug || 'parent'
   const parent = doc[parentSlug]
-  let retrievedParent
+  let retrievedParent: null | Record<string, unknown> = null
 
   if (parent) {
     // If not auto-populated, and we have an ID
@@ -27,7 +27,7 @@ export const getParents = async (
 
     // If auto-populated
     if (typeof parent === 'object') {
-      retrievedParent = parent
+      retrievedParent = parent as Record<string, unknown>
     }
 
     if (retrievedParent) {

packages/plugin-nested-docs/tsconfig.json

@@ -1,8 +1,4 @@
 {
   "extends": "../../tsconfig.base.json",
-  "compilerOptions": {
-    /* TODO: remove the following lines */
-    "strict": false,
-  },
   "references": [{ "path": "../payload" }]
 }