fix(next): prevent locale upsert when not authenticated #13621
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrikKozak
approved these changes
Oct 2, 2025
|
🚀 This is included in version v3.59.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When
?locale=is present in an admin panel URL and that admin panel URL is visited in an unauthenticated browser, a runtime error is thrown.Why?
upsertPreferencesrelies onreq.userto successfully create a newpayload-preferencesdocument. When an unauthenticated user visits a URL with alocaleparameter,upsertPreferencesis called butreq.useris not available.How?
Prevent
upsertPreferencesfrom being called whenreq.useris not available.Fixes #13581