Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Express-fileupload options #180

Closed
EKMN opened this issue May 13, 2021 · 3 comments · Fixed by #183
Closed

Express-fileupload options #180

EKMN opened this issue May 13, 2021 · 3 comments · Fixed by #183
Labels
documentation Improvements or additions to documentation

Comments

@EKMN
Copy link

EKMN commented May 13, 2021

Documentation Issue

The default upload behaviour is to load everything to memory. This is not really feasible when dealing with large files.

Further, the docs are confusing. It is implied that all valid express-fileupload options (like useTempFiles) are supported, however adding anything but upload.limits.fileSize throws an error due to validation failure.

If this limited behaviour is intended, then the docs should probably reflect that.

Additional Details

none
@EKMN EKMN added the documentation Improvements or additions to documentation label May 13, 2021
@denolfe
Copy link
Member

denolfe commented May 13, 2021

Thank you for the report @EKMN! We'll look into either supporting all options or a subset, then updating the docs accordingly.

@jmikrut jmikrut mentioned this issue May 16, 2021
Merged
3 tasks
jmikrut added a commit that referenced this issue May 16, 2021
@jmikrut
fix: misc responsive improvements, date clipping in sidebar (#165), e…
a2e57b0 
…xpress-fileupload schema validation (#180)

* fix: misc responsive improvements
* fix: date clipping in sidebar
* fix: revises popup
* fix: admin _verified field not displaying proper field value
* fix: properly typed express-fileupload config options
@jmikrut
Copy link
Member

jmikrut commented May 16, 2021

Hey @EKMN —

Good call here. Just some bad schema validation. All express-fileupload options are available for your use and are now validated / typed accordingly.

Give the new version a shot and thank you!

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 8, 2024

This issue has been automatically locked.
Please open a new issue if this issue persists with any additional detail.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: misc responsive improvements, date clipping in sidebar payloadcms/payload
3 participants
@denolfe @jmikrut @EKMN