Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensures valid value is always passed to value prop, e.g. reset t… #3413

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

PatrikKozak
Copy link
Contributor

…o default value

Description

Handles null case of compare version select by reseting to the default value.

  • I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Existing test suite passes locally with my changes

@PatrikKozak PatrikKozak linked an issue Sep 29, 2023 that may be closed by this pull request
@denolfe denolfe added the base: 1.x PR targets old 1.x branch label Oct 10, 2023
@JarrodMFlesch JarrodMFlesch merged commit 6b3f20d into 1.x Oct 27, 2023
1 of 3 checks passed
@JarrodMFlesch JarrodMFlesch deleted the fix/compare-version-select branch October 27, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base: 1.x PR targets old 1.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin dashboard crashes after clicking "clear" button in "compare version" select
3 participants