Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db-postgres): indexes not created for non unique field names #4967

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

DanRibbens
Copy link
Contributor

@DanRibbens DanRibbens commented Feb 1, 2024

Description

While working with the Drizzle team on some other issues it was discovered that our index naming method was preventing all of the indexes from being made properly because they need to be unique across all table names.

Changes include

  • naming of indexes

  • fixed condition to cover hasMany: true text fields

  • I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

  • Chore (non-breaking change which does not add functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Change to the templates directory (does not affect core functionality)
  • Change to the examples directory (does not affect core functionality)
  • This change requires a documentation update

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • Existing test suite passes locally with my changes
  • I have made corresponding changes to the documentation

@denolfe denolfe merged commit 64f705c into main Feb 1, 2024
30 checks passed
@denolfe denolfe deleted the fix/postgres-unique-index-names branch February 1, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants