APPS-11359 Dependency Bump for Ruby 3.0 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The String encoding method now takes a variable amount of arguments with the last being keyword args. Due to this, the double splats are required to change any hashes or constants into the proper arg to the encoding method.
There is a need to bump the Holidays gem here into a state that supports Ruby 3.0 and beyond. There are also a few quick wins here regarding other gems if we bump the dev dependencies.
In later versions of the Holidays gem, the federal_reserve param has had it's underscore removed. Fixed to properly generate expected holidays.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Tracker