This repository has been archived by the owner on Nov 21, 2018. It is now read-only.
Add Provider testing functionality #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: lib/rester/errors.rb
| With valid card details: | ||
| request: | ||
| body: | ||
| card_number: "4111111111111111", |
There was a problem hiding this comment.
Remove body: here from the example.
| response = @stub[path][verb][context]['response'] | ||
| rescue NoMethodError => e | ||
| raise Rester::Errors::StubError, | ||
| "Could not find path: #{path.inspect} verb: #{verb.inspect} context: #{context.inspect} in #{@stub_filepath}" |
There was a problem hiding this comment.
Don't define the e variable if it's not used.
rescue NoMethodError
...
endAlso use fail here instead of raise.
|
This is starting to look pretty good! |
roberthoner
pushed a commit
that referenced
this pull request
Nov 5, 2015
Add Provider testing functionality
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#28]