Bumping up mesos-go, thrift, and gorealis dependencies. #120
Conversation
| github.com/mitchellh/mapstructure v1.3.2 // indirect | ||
| github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e // indirect | ||
| github.com/paypal/gorealis v1.1.0 | ||
| github.com/paypal/gorealis v1.23.0 |
There was a problem hiding this comment.
can I know why we have to stick with gorealis v1? I don't remember it.
There was a problem hiding this comment.
Gorealis v2 changed some of the underlying objects around. We can probably help the DCE-go maintainers to move over to the newest version though, shouldn't be too hard.
| @@ -26,8 +26,8 @@ import ( | |||
| "syscall" | |||
| "time" | |||
|
|
|||
| exec "github.com/mesos/mesos-go/executor" | |||
| mesos "github.com/mesos/mesos-go/mesosproto" | |||
| exec "github.com/mesos/mesos-go/api/v0/executor" | |||
There was a problem hiding this comment.
I saw some use exec, some don't.
also we have os/exec. I think it may confuse us. It would be best to make it consistent.
There was a problem hiding this comment.
This is something definitely worth looking into, for this change I just wanted to make the changes as minimal as possible.
| @@ -20,7 +20,7 @@ import ( | |||
| "strconv" | |||
| "testing" | |||
|
|
|||
| "github.com/mesos/mesos-go/mesosproto" | |||
| "github.com/mesos/mesos-go/api/v0/mesosproto" | |||
There was a problem hiding this comment.
in the impl.go, we use "mesos", in this file we don't.
There was a problem hiding this comment.
some other files don't use mesos "..." too.
There was a problem hiding this comment.
Good point, there's very little consistency here in terms of renaming imports.
Mesos-go v0.0.3-snapshot -> v0.0.11
gorealis v1.1.0 -> v1.23.0
thrift v0.0.0-snapshot -> v0.14.0