set http timeout #57
Merged
set http timeout #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- increase the sleep time to reduce the race condition of mesos state update and driver.stop
kkrishna
approved these changes
Oct 4, 2018
at15
reviewed
Oct 4, 2018
| @@ -37,7 +38,7 @@ func GenBody(t interface{}) io.Reader { | |||
|
|
|||
| // http post | |||
| func PostRequest(url string, body io.Reader) ([]byte, error) { | |||
| client := &http.Client{} | |||
| client := &http.Client{Timeout: config.GetHttpTimeout()} | |||
There was a problem hiding this comment.
Actually when you are using http.Client without passing http.Transport, it will be using the default http.DefaultTransport, see https://medium.com/@nate510/don-t-use-go-s-default-http-client-4804cb19f779 the timeout on client is coarse grained, better control need to go through http.Transport
There was a problem hiding this comment.
Good catch. It's a good idea to create an instance of http.Transport and use it instead of relying on the default transport. The default transport has a few surprising properties that may come back and bite you.
There was a problem hiding this comment.
created issue on this #59, will fix it in next release. Thx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
executor will be killed before sending out mesos task status. To reduce the issue for now, increasing sleep time before stop driver.