Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logging] Refactor Gimel Logger #60

Closed
meisam opened this issue Apr 10, 2018 · 1 comment
Closed

[Logging] Refactor Gimel Logger #60

meisam opened this issue Apr 10, 2018 · 1 comment
Labels
Enhancement New feature or request

Comments

@meisam
Copy link
Contributor

meisam commented Apr 10, 2018

It is very difficult to unit-test Gimel, because a lot of dependencies, configurations, and options are hard-coded in Gimel source code and it is almost impossible to change them or mock them. Gimel should be refactored so we can unit-test Gimel.
meisam added a commit to meisam/gimel that referenced this issue Apr 10, 2018
@meisam
[paypal#60] Refactor Gimel Logger
6f447a3 
Making Gimel Logger a Scala trait.
Making classes/objects that need loging extend this trait.

 # TODO
 JSONLogger is set to None for now. It should be configurable,
 preferably from log4j.properties.
@meisam meisam mentioned this issue Apr 10, 2018
Closed
4 tasks
@Dee-Pac Dee-Pac changed the title Refactor Gimel Logger [Logging] Refactor Gimel Logger Apr 11, 2018
@Dee-Pac Dee-Pac added the Enhancement New feature or request label Apr 11, 2018
meisam added a commit to meisam/gimel that referenced this issue Apr 11, 2018
@meisam
[paypal#60] Refactor Gimel Logger
41f12d4 
Making Gimel Logger a Scala trait.
Making classes/objects that need loging extend this trait.

 # TODO
 JSONLogger is set to None for now. It should be configurable,
 preferably from log4j.properties.
@Dee-Pac
Copy link
Contributor

Dee-Pac commented Oct 19, 2019

We shall reopen the issue if a request arises.

@Dee-Pac Dee-Pac closed this as completed Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#60] [WIP] Refactor Gimel Logger meisam/gimel
2 participants
@meisam @Dee-Pac