This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
[WIP] test($typescript): Added test for when generating definition files #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 10 10
Lines 124 124
Branches 32 32
=====================================
Hits 124 124Continue to review full report at Codecov.
|
|
superseded by #124 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Work In Progress]
Doesn't make a lot of sense to land this until documentation also exists in Readme.
Also if anyone has any ideas on how to solve this in another way that would be great.
What:
Added a test for usage when generating definition files.
This is a bit of an odd test as the user is unlikely to know how to resolve this issue if they hit up against it.
It should be documented along with the typescript usage.
Why:
By default this doesn't work due to an issue with typescript.
microsoft/TypeScript#5938
How:
Adding flag to test typescript compiler options to create definitions.
Checklist:
Have not added documentation as there is not currently typescript usage documentation in the readme. Will open up a following pr to address #83 shortly.