Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable optional logging of bind value hash #286

Merged
merged 4 commits into from
Aug 24, 2022

Conversation

venkatsridhar95
Copy link
Collaborator

@venkatsridhar95 venkatsridhar95 commented Aug 24, 2022

If enable_bind_hash_logging is enabled - it will log the bind value hash to the EXEC CAL Txn.

Copy link
Contributor

@ModEtchFill ModEtchFill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could get big with some queries that have hundred+ binds.

I suspect the performance impact would be observable.

@venkatsridhar95
Copy link
Collaborator Author

I moved the changes to an existing loop rather than looping over the binds again. This would add the bind hashes to API (CLIENT_SESSION) data section.
This can potentially add overhead if enabled by default. It would be useful to enable it on an on-demand basis.

@ModEtchFill
Copy link
Contributor

Looks good to me. Having the hashes on the exec keeps it a bit easier to understand.

@venkatsridhar95 venkatsridhar95 merged commit e2c6ee6 into paypal:master Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants