Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restrict shard_key_auto_discovery event to str shard keys #383

Closed
wants to merge 4 commits into from
Closed

restrict shard_key_auto_discovery event to str shard keys #383

wants to merge 4 commits into from

Conversation

rsh-yam
Copy link
Contributor

@rsh-yam rsh-yam commented Dec 21, 2023 •
edited
Loading

Removing this event.
Keeping this event only for String type shard keys would help in debugging issues with #320.

shtiencode
shtiencode approved these changes Dec 28, 2023
View reviewed changes
Copy link
Collaborator

@shtiencode shtiencode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, thanks. We may also remove this for string shard key type in the future.

venkatsridhar95
venkatsridhar95 reviewed Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@venkatsridhar95 venkatsridhar95 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we add this information to the app logs with a verbose log level? It could be useful during any debug session.

@venkatsridhar95
Copy link
Collaborator

Functional test failure: https://github.com/paypal/hera/blob/main/tests/functionaltest/sharding_tests/shard_basic/main_test.go#L149 as it looks for the shard_key_auto_discovery CAL event.

@rsh-yam rsh-yam marked this pull request as draft January 2, 2024 23:45
@rsh-yam rsh-yam closed this Jan 6, 2024
@rsh-yam rsh-yam mentioned this pull request Jan 6, 2024
Merged
@rsh-yam
Copy link
Contributor Author

rsh-yam commented Jan 6, 2024

Replaced by #384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@venkatsridhar95 venkatsridhar95 venkatsridhar95 left review comments

@shtiencode shtiencode shtiencode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rsh-yam @venkatsridhar95 @shtiencode