Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove commented out codes in the repo #106

Open
varuntechie opened this issue May 19, 2023 · 2 comments · May be fixed by #139
Open

Remove commented out codes in the repo #106

varuntechie opened this issue May 19, 2023 · 2 comments · May be fixed by #139
Labels
good first issue Good for newcomers

Comments

@varuntechie
Copy link
Contributor

What I Did
Code walkthrough of the repo found there are many commented lines which should be removed

What I Expected
No commented code in any of the working file

What I Saw Instead
commented code in few of the working files.
Eg: (https://github.com/paypal/junodb/blob/main/test/unittest/create_test.go#L1158)
@varuntechie varuntechie added the good first issue Good for newcomers label May 19, 2023
@qashlan
Copy link

qashlan commented May 20, 2023

I can have this issue

@haseeb-xd haseeb-xd mentioned this issue May 20, 2023
Closed
This was referenced May 20, 2023
Closed
Closed
dustinpor2626 added a commit to dustinpor2626/junodb that referenced this issue May 21, 2023
@dustinpor2626
Update create_test.go
bfec6d7 
removed commented codes paypal#106
@dustinpor2626 dustinpor2626 mentioned this issue May 21, 2023
Closed
@Harshalyadav Harshalyadav mentioned this issue May 22, 2023
Closed
@mahendra1290
Copy link

@varuntechie can I pick this up?

@haseeb-xd haseeb-xd linked a pull request Jun 3, 2023 that will close this issue
Open
@varuntechie varuntechie mentioned this issue Jun 27, 2023
Open
@abhishek0909 abhishek0909 mentioned this issue Jul 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: removed commented code from create_test.go haseeb-xd/junodb
3 participants
@qashlan @mahendra1290 @varuntechie